feat(processor): support no-arg @ServiceProvider via contract inference - #13
feat(processor): support no-arg @ServiceProvider via contract inference#13LMLiam wants to merge 47 commits into
Conversation
…Gradle configuration
…version from gradle.properties
… setup instructions
…tes, feature requests, questions, refactor proposals, and test coverage requests
…and update versioning logic
…rove review process
Co-authored-by: LMLiam <46268350+TheRealEmissions@users.noreply.github.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8aa16d6ce6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| id 'org.gradle.toolchains.foojay-resolver-convention' version '0.8.0' | ||
| } | ||
|
|
||
| rootProject.name = 'spi-tooling' |
There was a problem hiding this comment.
Removing the Foojay toolchains resolver here means Gradle no longer has any toolchain download repository configured. The modules still request Java 24 toolchains (see modules/annotations/build.gradle and modules/processor/build.gradle), so any environment without a locally installed JDK 24 will now fail toolchain resolution with “no compatible toolchain” instead of provisioning one. If the intent is to avoid network access during settings evaluation, consider an alternative local toolchain repo configuration or lowering the toolchain version to what’s already installed rather than dropping resolver support entirely.
Useful? React with 👍 / 👎.
LMLiam
added
type:feature
LMLiam
changed the title
LMLiam
changed the title
1 participant
Description
settings.gradleto avoid mandatory plugin resolution during settings evaluation.@ServiceProviderusage by givingServiceProvidera default emptyvalueand implementinginferContractsFromProviderinServiceSchemeProcessorto BFS supertypes and collect@ServiceContractinterfaces; emit a clear compilation error when none can be inferred.ServiceSchemeProcessorSpec.kt.Codex Task