Skip to content

fix unet bottleneck dim off by 1 error #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PatrickRMiles wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix unet bottleneck dim off by 1 error #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f2c8ce6
fix unet bottleneck dim off by 1 error
Mar 17, 2026
506024b
ruff
Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions ScaFFold/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,9 +193,7 @@ def main():

# Recalculate unet_layers to capture any CLI overrides
combined_config["unet_layers"] = (
combined_config["problem_scale"]
- combined_config["unet_bottleneck_dim"]
+ 1
combined_config["problem_scale"] - combined_config["unet_bottleneck_dim"]
)

# Resolve paths to absolute, matching Config() behavior
Expand Down
2 changes: 1 addition & 1 deletion ScaFFold/utils/config_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ def __init__(self, config_dict):
)
self.problem_scale = math.floor(self.problem_scale)
self.unet_bottleneck_dim = config_dict["unet_bottleneck_dim"]
self.unet_layers = self.problem_scale - self.unet_bottleneck_dim + 1
self.unet_layers = self.problem_scale - self.unet_bottleneck_dim
self.n_fracts_per_vol = config_dict["n_fracts_per_vol"]
self.n_instances_used_per_fractal = config_dict["n_instances_used_per_fractal"]
self.scale = 1
Expand Down
Loading