Skip to content

Release: final JOSS paper corrections - #464

Merged
phanindra-max merged 4 commits into
mainfrom
dev
Nov 8, 2026
Merged

phanindra-max merged 4 commits into
mainfrom
dev

Conversation

@phanindra-max

@phanindra-max phanindra-max commented Nov 8, 2026 •

Copy link
Copy Markdown
Member

Brings #463 and #465 to main, the branch the JOSS paper is built from.

  • Spells out NLP at first use.
  • Completes the AI usage disclosure with Claude Sonnet 4.6 and Claude Opus 5.5.
  • Names the OpenAI Responses API in Software design.
  • Adds laiser setup to the install line.

Only paper.md changes.

Refs #424, #447

🤖 Generated with Claude Code

phanindra-max and others added 2 commits November 8, 2026 17:31
The Statement of need rewrite used "NLP" before defining it. Define it
there and use the abbreviation in State of the field, which keeps the
paper within the JOSS word limit.

Refs #424, #447

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI balanced review requested due to automatic review settings November 8, 2026 22:31

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@github-actions

github-actions Bot commented Nov 8, 2026

Copy link
Copy Markdown

Code Hygiene

The following items are defined but not yet in active use. Routine cleanup — no impact on functionality.

  • laiser/llm_methods.py:87 — unused variable 'args' (100% confidence)
  • laiser/llm_models/llama_cpp_handler.py:45 — unused variable 'chat_format' (100% confidence)
  • laiser/llm_models/llama_cpp_handler.py:86 — unused variable 'exc_type' (100% confidence)
  • laiser/llm_models/llama_cpp_handler.py:86 — unused variable 'tb' (100% confidence)
  • laiser/llm_models/llm_router.py:71 — unused variable 'args' (100% confidence)
  • laiser/llm_models/llm_router.py:86 — unused variable 'args' (100% confidence)
  • laiser/llm_models/llm_router.py:89 — unused variable 'args' (100% confidence)
  • laiser/services.py:128 — unused variable 'raw_description' (100% confidence)

@github-actions

github-actions Bot commented Nov 8, 2026

Copy link
Copy Markdown

Complexity Analysis

Average: C — Moderate (13.909090909090908)

Hotspots tracked below. These are functional, well-exercised components — listed for visibility as the codebase scales.

Grade Name Type Score
F FAISSIndexManager.initialize_index Method 53
E SkillExtractionService.extract_and_align_core Method 36
E FAISSIndexManager.search_similar_skills Method 32
D ResponseParser._parse_skills_from_response Method 24
D FAISSIndexManager Class 23
C ResponseParser.parse_knowledge_task_response Method 20
C _BaseTaxonomyFAISSIndexManager.search_similar Method 18
C ResponseParser Class 17
C ResponseParser.parse_ksa_extraction_response Method 16
C ResponseParser.parse_skill_extraction_response Method 15
C openai_generate Function 14
C _download_bundle Function 13
C parse_output_vllm Function 13
C AlignmentService.align Method 11
C _BaseTaxonomyFAISSIndexManager.initialize_index Method 11
C LLMRouter._initialize_components Method 11
C anthropic_generate Function 11
B SkillExtractionService._deduplicate Method 10
B GeminiAPI.generate_with_config Method 10
B load_model_from_vllm Function 10
B _BaseTaxonomyFAISSIndexManager Class 9
B ResponseParser.parse_ksa_details_response Method 8
B SkillExtractionService Class 8
B llm_generate Function 8
B SkillExtractorRefactored._expand_allowed_sources Method 7
B get_completion_vllm Function 7
B LLMRouter.generate Method 7
B llama_cpp_chat Function 7
B AlignmentService Class 6
B SkillExtractionService._normalize_mixed_concept_rows Method 6
B fetch_model_output Function 6
B GeminiAPI Class 6
B LlamaCppBackend.__init__ Method 6

phanindra-max and others added 2 commits November 8, 2026 17:36
Commit history shows Claude Sonnet 4.6 and Claude Opus 5.5 also wrote
code, so name them in the disclosure. Name the OpenAI Responses API,
which is the API the backend uses and the one that accepts no seed. Add
`laiser setup` to the install line, which has been required since #462.

Refs #447

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
docs(paper): complete the AI disclosure and correct two details
@phanindra-max phanindra-max changed the title Release: spell out NLP in the JOSS paper Release: final JOSS paper corrections Nov 8, 2026
@phanindra-max phanindra-max self-assigned this Nov 8, 2026
@phanindra-max
phanindra-max merged commit 7219a03 into main Nov 8, 2026
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants