chore(verify): compat workers default 16, --fail-fast/--keep-going (#236 C5–C7) - #238
Merged
Merged
Conversation
…he worker `--fail-fast` skips every remaining serial lane once one has come back red and is the default for `--full`; `--keep-going` restores run-every-lane and stays the fast gate's default, since its three lanes are already running when the first red appears. A cut lane keeps its row in the lane table as `skipped (--fail-fast)` so it can never be mistaken for a lane the mode does not have. `VERIFY_FULL_COMPAT_WORKERS` defaults to 16, matching the 40-core rexec worker that actually runs the gate rather than the retired 21-core workstation. Refs #236
chrisdpurcell
marked this pull request as ready for review
September 1, 2026 20:25
This was referenced Sep 1, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/verify.sh:VERIFY_FULL_COMPAT_WORKERSdefaults to 16 (sized for the rexec worker, the only machine that runs--full); new--fail-fast(default under--full) and--keep-goingflags — a red lane skips the remaining serial lanes, reported asskipped (--fail-fast)in the lane table with the red exit preserved.tests/issue_regressionswas confirmed already inside the ordinary selector (49 tests collected), so C7's repository half needed no change.Governing work
Supporting: #236
Acceptance coverage
scripts/verify.sh:80; workstation rationale removed from the header.--fail-fast/--keep-going;tests/test_repository_test_gate.pyproves a red ordinary lane skips compatibility/performance and that--keep-goingruns them (4 new/changed tests red on the old script, 16 passed after).pytest -m "not performance and not compatibility" --collect-only tests/issue_regressions→ 49 collected; no committed fast-gate list exists to amend.Verification
bash -n,uv run pytest tests/test_repository_test_gate.py -q(16 passed), ruff format/check, basedpyright, prettier + markdownlint on CHANGELOG.md — all exit 0. No src/ or payload change; integrated battery runs on the final tree.