Skip to content

fix: use variant colour for invert button hover#4

Open
puneetdixit200 wants to merge 1 commit into
KyrnDev:mainfrom
puneetdixit200:fix/button-invert-hover-colour
Open

fix: use variant colour for invert button hover#4
puneetdixit200 wants to merge 1 commit into
KyrnDev:mainfrom
puneetdixit200:fix/button-invert-hover-colour

Conversation

@puneetdixit200

Copy link
Copy Markdown

Summary

  • keep the base button text using the existing on-* contrast token
  • add a separate invert-hover text token based on the button variant colour
  • apply that token to the invert hover text and border colour
  • add a component spec covering the invert hover token behavior

Closes #2.

Validation

  • bun run lint
  • bun run test (9 files, 48 tests)
  • git diff --check

AI assistance

This PR was prepared with AI assistance. I reviewed the component behavior, kept the change scoped to LxButton, added a targeted Vitest spec, and ran the project lint/test checks before submission.

Signed-off-by: Puneet Dixit <236133619+puneetdixit200@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Button hover mode of invert, the text now incorrectly shows the contrasted colour.

1 participant