Modernize code and dependencies for React 18 and 19#214
Open
jessetan wants to merge 1 commit intoKyleAMathews:masterfrom
Open
Modernize code and dependencies for React 18 and 19#214jessetan wants to merge 1 commit intoKyleAMathews:masterfrom
jessetan wants to merge 1 commit intoKyleAMathews:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR upgrades react-headroom to be compatible with React 19 while maintaining backward compatibility with React 18. It also modernizes the entire dependency ecosystem and toolchain.
This was co-written with AI, but guided and tested with love and care by a real human.
As far as I can see, this is functionally equivalent to the current package, I have not updated the package version nor the README. The doc site was removed as it would be another migration.
I hope this PR will help others, even if it never gets merged.
Key Changes
React 19 Compatibility
Dependency Modernization
Breaking Changes
Migration
Users on React 18+ can upgrade directly. For React <18, stay on the previous version.
The upgrade maintains all existing APIs and functionality while eliminating deprecation warnings and providing a modern development experience that is compatible with latest React.