use goldmark ecosystem to define options#32
Open
Kunde21 wants to merge 1 commit into
Open
Conversation
Allow extensions to register rendering functions.
Collaborator
|
I would not consider goldmark a good example on how to do extensions will write later when I get more time :D |
Owner
Author
|
Not the one I would design if we were starting from scratch, but the goldmark ecosystem already exists using this pattern. |
bwplotka
reviewed
Feb 7, 2021
bwplotka
left a comment
bwplotka
left a comment
Collaborator
There was a problem hiding this comment.
I am ok with any of this. Anything that makes our life simpler (: I don't think we are forced to use goldmark pattern. Even what you suggests looks the same on our API level, so does not matter for me 🤗
Up to you, lgtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial idea on adding extensions and render options to markdownfmt.