Skip to content

feat(macos): add system menu and shortcuts - #288

Draft
WilliamWang1721 wants to merge 9 commits into
Kuddev:mainfrom
WilliamWang1721:codex/macos-system-menu
Draft

WilliamWang1721 wants to merge 9 commits into
Kuddev:mainfrom
WilliamWang1721:codex/macos-system-menu

Conversation

@WilliamWang1721

@WilliamWang1721 WilliamWang1721 commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

Result / 用户结果

macOS 使用原生应用菜单栏,提供 Pebrel、File、Edit、View 和 Window 菜单。⌘Q 走已有安全退出流程;⌘W 关闭窗口并沿用文档/会话检查,活动终端关闭改为 ⌘⇧W。

Design / 设计边界

  • GPUI workspace 注册系统菜单和 macOS 快捷键;菜单文案使用现有 typed i18n。
  • 动作声明从超预算的 workspace 文件提到 actions.rs;没有依赖、持久化格式或线程模型变化。
  • 英文和简体中文提供新词条;其他语言按现有合同回退英文。

Evidence / 验证依据

  • PASS: git diff --check
  • PASS: python3 scripts/check_architecture.py --base 9dc058d12765893553d5fc7a2c37c870c96168b0
  • PASS: 英文和简体中文 JSON 有效且消息 ID 对齐
  • NOT RUN: cargo check(当前环境没有 cargo)
  • NOT RUN: macOS 原生菜单和键盘交互实测
  • 未添加或运行行为测试;此 PR 保持 Draft,等待 Rust/macOS 环境验证。

Required Review / 必须确认

  • 已阅读 CONTRIBUTING.md、docs/architecture.md 和 docs/project-constraints.md。
  • 按职责提取动作声明,未增加重复行为权威。
  • 基线架构检查通过,未抬高预算。
  • 成功/失败行为测试和 macOS 实机覆盖待补。
  • 新文案使用 typed i18n ID,英语和简体中文目录 ID 对齐,其他语言回退英文。
  • 治理规则未变更。

UI Review Screenshots

Current-head evidence for a4513de407f537facfb5ab5906684bd76bd182fa. UI review workflow run

Windows — success

PR #288 — Windows — 00-full-app-review.png

PR #288 — Windows — 01-platform-regression-review.png

Raw evidence: Windows originals

macOS — success

PR #288 — macOS — 00-full-app-review.png

PR #288 — macOS — 01-native-menu-review.png

Raw evidence: macOS originals

github-actions Bot added a commit to WilliamWang1721/pebrel that referenced this pull request Sep 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant