Show platform-specific shortcut modifiers - #287
Open
WilliamWang1721 wants to merge 6 commits into
Open
WilliamWang1721 wants to merge 6 commits into
WilliamWang1721 wants to merge 6 commits into
Conversation
WilliamWang1721
force-pushed
the
codex/platform-shortcut-labels
branch
from
September 24, 2026 13:14
eee0f71 to
b888255
Compare
github-actions Bot
added a commit
to WilliamWang1721/pebrel
that referenced
this pull request
Sep 25, 2026
github-actions Bot
added a commit
to WilliamWang1721/pebrel
that referenced
this pull request
Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Result / 用户结果
Shortcut labels now use the running platform's modifier names: macOS shows Command and Option, Windows shows Win and Alt, and Linux shows Super and Alt. The read-only numbered-tab row also includes Command+1..9 on macOS. No issue link was provided.
Design / 设计边界
nebula_app/src/display/keymap.rsowns shared shortcut labels used by both settings shells and shortcut hints.Evidence / 验证依据
git diff --check: passed.python3 scripts/check_architecture.py --base 9dc058d12765893553d5fc7a2c37c870c96168b0: reports two unchanged base-file limits (display/mod.rs11067/11064;display/settings.rs8407/8406). This PR changes onlydisplay/keymap.rs.cargois unavailable.Required Review / 必须确认
CONTRIBUTING.md,docs/architecture.md, anddocs/project-constraints.md.python3 scripts/check_architecture.py --base <PR-base-commit>passes; budgets were not inflated to fit the change. (The checker reports the two unchanged base-file limits listed above.)UI Review Screenshots
Current-head evidence for
0319fb7534d287bd4cbd41431d99251436e7bdda. UI review workflow runWindows — success
Raw evidence: Windows originals
macOS — success
Raw evidence: macOS originals