Skip to content

默认启用侧边栏宽度拖拽 - #284

Merged
Kuddev merged 11 commits into
Kuddev:mainfrom
WilliamWang1721:codex/sidebar-resize
Sep 25, 2026
Merged

Kuddev merged 11 commits into
Kuddev:mainfrom
WilliamWang1721:codex/sidebar-resize

Conversation

@WilliamWang1721

@WilliamWang1721 WilliamWang1721 commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

结果 / 用户结果

侧栏宽度拖拽默认开启,用户仍可在设置中关闭分隔线拖动。

设计 / 设计边界

  • 修改共享运行时设置与旧壳默认值,复用已有 GPUI 拖拽、宽度限制和持久化逻辑。
  • 未增加依赖或改变配置格式;显式设置 panel_resize=0 仍会锁定分隔线。

Evidence / 验证依据

  • python3 scripts/check_architecture.py --base 9dc058d12765893553d5fc7a2c37c870c96168b0:通过。
  • git diff --check:通过。
  • 回归断言覆盖默认开启与显式关闭;尚未运行,当前环境没有 cargo。
  • 尚未进行 macOS 原生拖拽和视觉验收。

Required Review / 必须确认

  • 已遵循 CONTRIBUTING.md、架构与工程约束。
  • 复用现有设置与拖拽实现,没有新增重复行为权威。
  • 架构预算检查通过,未增加预算。
  • Rust 回归测试尚未运行;macOS 原生交互验收待完成。
  • 未新增 UI 文案或 i18n 消息。
  • 不涉及治理规则变更。

UI Review Screenshots

Current-head evidence for fee47d936225aef975bf7c4ec136b3e063fe6dde. UI review workflow run

Windows — success

PR #284 — Windows — 00-full-app-review.png

PR #284 — Windows — 01-sidebar-settings-review.png

Raw evidence: Windows originals

macOS — success

PR #284 — macOS — 00-full-app-review.png

PR #284 — macOS — 01-sidebar-settings-review.png

Raw evidence: macOS originals

@WilliamWang1721
WilliamWang1721 marked this pull request as ready for review September 24, 2026 14:38
github-actions Bot added a commit to WilliamWang1721/pebrel that referenced this pull request Sep 25, 2026
github-actions Bot added a commit to WilliamWang1721/pebrel that referenced this pull request Sep 25, 2026

@Kuddev Kuddev left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

???????????????????

  • ????? panel_resize ????????? panel_resize=0 ?????????????
  • ??????????????????????????????????????????? #140 ????? GPUI ?????????????????
  • ???? PR ????? PR ?????? PR ??????????? workflow??????????????????????????????????????
  • ?? nebula-settings 71 ???????????? diff ?????
  • ???? 692839b303a8667f608e5c2b4007f588c1d8a728 ? 10 ??????????????????????? macOS release-workspace ???

CI?https://github.com/Kuddev/pebrel/actions/runs/36158512554

@Kuddev
Kuddev merged commit b6bf254 into Kuddev:main Sep 25, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants