feat(workspace): open project folders in new terminal tabs - #130
Open
Aschenbath wants to merge 1 commit into
Open
Aschenbath wants to merge 1 commit into
Aschenbath wants to merge 1 commit into
Conversation
This was referenced Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Result / 用户结果
Fixes #124.
Design / 设计边界
Evidence / 验证依据
Local checks on this branch:
cargo +1.97.1 test --offline --locked -p nebula --bin pebrel --features gpui-test-support -- --test-threads=1cargo +1.97.1 check --offline --locked -p nebula --bin pebrel --features gpui-shell --testscargo +1.97.1 test --offline --locked --manifest-path tools/i18n-contract/Cargo.tomlpython -B scripts/check_architecture.py --base ce068600b2382d71301070535dcdb4e038156b56python -B -m unittest scripts.tests.test_architecture_budgets scripts.tests.test_architecture_dependencies scripts.tests.test_architecture_governancerustfmt --edition 2024 --config skip_children=true --check;git diff --checkEight focused regressions cover both actual toolbar layouts, full padded hit area, duplicate clicks, the single-directory picker contract, cancel/retry, real Tab/Enter routing, invalid/file selections, picker failure, workspace closure, failed shell startup, profile snapshot isolation, and Unicode/space-containing paths.
The opt-in Windows native acceptance test was also run successfully in Nord/sidebar (1080 logical pixels wide) and MintLight/top tabs (760 logical pixels wide) at 192 DPI / 200% scaling. It creates isolated test terminals, checks the new shell's actual working directory, and verifies that the original tab/entity and cwd remain unchanged. Screenshots below show the real toolbar's keyboard focus in both layouts; fixture paths and terminal contents are excluded.
Limits: the native acceptance test injects the selected directory at the picker-result boundary so it does not open a modal dialog over other work. The picker/button/cancel/keyboard route is exercised separately with GPUI test support; manual Windows picker interaction, Linux/macOS native behavior, WSL/UNC directories and other DPI values are not verified here. Full-workspace
cargo fmt --all -- --checkstill reports unrelated existing formatting differences; only changed Rust files were formatted. These are local results, not a claim about CI or a released build.No render hot loop is changed; filesystem work only occurs after an explicit folder selection. The installed application was not replaced or restarted for this PR.
Required Review / 必须确认
CONTRIBUTING.md,docs/architecture.md, anddocs/project-constraints.md.python3 scripts/check_architecture.py --base <PR-base-commit>passes; budgets were not inflated to fit the change.