Skip to content

Add type argument to plot_jn()#126

Merged
Kss2k merged 8 commits intomainfrom
conditional-jn-plot
Feb 18, 2026
Merged

Add type argument to plot_jn()#126
Kss2k merged 8 commits intomainfrom
conditional-jn-plot

Conversation

@Kss2k
Copy link
Owner

@Kss2k Kss2k commented Feb 17, 2026

Implement feature request #125

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 30c2fd88c4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines 194 to 197
parTable <- parameter_estimates(
object = model,
label.renamed.prod = TRUE
)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Request colonized product names for indirect/total JN

For modsem_pi objects, parameter_estimates() defaults to colon.pi = FALSE, so interaction RHS are typically stored like XZ instead of X:Z; in that case the new indirect/total branch later calls getIntTerms() (which only matches :) and immediately raises “No interaction terms were found,” making plot_jn(type = "indirect"|"total") unusable for a supported model class. Please pass colon.pi = TRUE (or otherwise normalize interaction names) when building parTable for this path.

Useful? React with 👍 / 👎.

@Kss2k Kss2k merged commit d5cfee8 into main Feb 18, 2026
6 checks passed
@Kss2k Kss2k deleted the conditional-jn-plot branch February 18, 2026 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments