Repository navigation
Extract the valid listen event definition enforcement into a dedicated module - #25
Merged
Merged
Conversation
… defining what constitutes a valid listen event
… to make filtering raw events part of the data pipeline flow
…he logic related to filtering out non-listen events
…define it as a module-level constant in features/preprocessing.py
…and define it as a module-level constant in features/sessionization.py
…ning only listen events that comply with the listen event definition
…s, improve the docstrings making them more informative and 'transparent'
…od from DataPipeline (caching is handled directly in specific methods)
…-level, fix minor typos in docstrings
…ationPipeline, expose listens_lf arg instead of events_lf, replace TensorizedSplit with TensorizedDataset argument to evaluate() method to let the caller decide on which split the evaluation will be run
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #23
Changelog:
src/impact/features/preprocessing.py: extracted the logic that enforces valid listen events definition into a separate, dedicated module.src/impact/features/sessionization.py: remove filtering out non-listen events.src/impact/models/actr/history_index.py: remove filtering out non-listen events.src/impact/pipelines/impact_evaluation_pipeline.py: renamed and adjusted ImpactEvaluationPipeline so that it acceptslistens_lfinstead ofevents_df, replacedTensorizedSplitwithTensorizedDatasetargument toevaluate()method to let the caller decide on which split the evaluation will be run.src/impact/pipelines/data_pipeline.py: unified the logic across allDataPipelinemethods, improved the docstrings making them more informative and 'transparent'.src/impact/utils.py: moved all import statements to the top-level (module level).src/impact/main.py,scripts/*).