Skip to content

fix(ci): add reusable/cargo-deny.yml at expected subdir path#97

Merged
KooshaPari merged 1 commit into
mainfrom
fix/add-reusable-cargo-deny-subdir
Jun 2, 2026
Merged

fix(ci): add reusable/cargo-deny.yml at expected subdir path#97
KooshaPari merged 1 commit into
mainfrom
fix/add-reusable-cargo-deny-subdir

Conversation

@KooshaPari
Copy link
Copy Markdown
Owner

@KooshaPari KooshaPari commented Jun 2, 2026

User description

Summary

  • Creates .github/workflows/reusable/cargo-deny.yml at the path consumers expect
  • Identical content to the existing flat reusable-cargo-deny.yml
  • Fixes workflow-parse-level failures in 5 repos that call uses: KooshaPari/phenotype-tooling/.github/workflows/reusable/cargo-deny.yml@main:
    • phenoRouterMonitor, phenotype-bus, phenotype-journeys, Authvault, PhenoObservability

Test plan

  • Verify post-merge that phenotype-journeys cargo-deny runs without workflow-parse error

Note

Low Risk
CI-only addition duplicating an existing reusable workflow; no application or security logic changes.

Overview
Adds .github/workflows/reusable/cargo-deny.yml so downstream repos can workflow_call the path they already reference (…/reusable/cargo-deny.yml@main). The workflow is the same reusable cargo-deny job as the flat reusable-cargo-deny.yml: checkout, stable Rust toolchain, and EmbarkStudios/cargo-deny-action.

This unblocks CI in repos that were failing at workflow parse time because the nested path did not exist, without changing the deny steps or permissions (contents: read).

Reviewed by Cursor Bugbot for commit 4ab44a5. Bugbot is set up for automated code reviews on this repo. Configure here.


CodeAnt-AI Description

Make the reusable cargo-deny workflow available at the path downstream repos already use

What Changed

  • Adds the reusable cargo-deny workflow at .github/workflows/reusable/cargo-deny.yml
  • Lets dependent repositories call the workflow without workflow-parse failures
  • Keeps the same cargo-deny checks available through the expected nested path

Impact

✅ Fewer CI failures in dependent repos
✅ Working cargo-deny runs from the expected workflow path
✅ Faster unblock for repos using the shared security check

💡 Usage Guide

Checking Your Pull Request

Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.

Talking to CodeAnt AI

Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

@codeant-ai ask: Your question here

This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

Example

@codeant-ai ask: Can you suggest a safer alternative to storing this secret?

Preserve Org Learnings with CodeAnt

You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:

@codeant-ai: Your feedback here

This helps CodeAnt AI learn and adapt to your team's coding style and standards.

Example

@codeant-ai: Do not flag unused imports.

Retrigger review

Ask CodeAnt AI to review the PR again, by typing:

@codeant-ai: review

Check Your Repository Health

To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.

Consumers reference `uses: KooshaPari/phenotype-tooling/.github/workflows/reusable/cargo-deny.yml@main`
but the file only existed at the flat path `reusable-cargo-deny.yml`.
Creating the subdir path fixes workflow-parse failures in:
- phenoRouterMonitor
- phenotype-bus
- phenotype-journeys
- Authvault
- PhenoObservability
@codeant-ai
Copy link
Copy Markdown

codeant-ai Bot commented Jun 2, 2026

CodeAnt AI is reviewing your PR.


Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

@gemini-code-assist
Copy link
Copy Markdown

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 2, 2026

Warning

Review limit reached

@KooshaPari, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 25 minutes and 2 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 42787ae3-db59-438f-92cf-3b00b43433f1

📥 Commits

Reviewing files that changed from the base of the PR and between 70fe06b and 4ab44a5.

📒 Files selected for processing (1)
  • .github/workflows/reusable/cargo-deny.yml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/add-reusable-cargo-deny-subdir
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch fix/add-reusable-cargo-deny-subdir

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@KooshaPari KooshaPari merged commit bed6437 into main Jun 2, 2026
10 of 11 checks passed
@KooshaPari KooshaPari deleted the fix/add-reusable-cargo-deny-subdir branch June 2, 2026 03:15
@codeant-ai codeant-ai Bot added the size:S This PR changes 10-29 lines, ignoring generated files label Jun 2, 2026
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Jun 2, 2026

@codeant-ai
Copy link
Copy Markdown

codeant-ai Bot commented Jun 2, 2026

CodeAnt AI finished reviewing your PR.

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is ON, but it could not run because the branch was deleted or merged before autofix could start.

Reviewed by Cursor Bugbot for commit 4ab44a5. Configure here.

- name: Run cargo-deny
uses: EmbarkStudios/cargo-deny-action@91bf2b620e09e18d6eb78b92e7861937469acedb # v6
with:
rust-version: stable
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate reusable workflow without removing original

Low Severity

This new file is a full duplicate of reusable-cargo-deny.yml (only the comment path differs). The internal caller .github/workflows/cargo-deny.yml still references the old flat path, so both copies will coexist. Future updates to one (e.g., bumping action pins or changing the runner) risk not being applied to the other, leading to drift between the two identical workflows.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 4ab44a5. Configure here.

@kilo-code-bot
Copy link
Copy Markdown

kilo-code-bot Bot commented Jun 2, 2026

Code Review Summary

Status: 1 Issue Found (Already Noted) | Recommendation: Note

Overview

Severity Count
CRITICAL 0
WARNING 1
SUGGESTION 0
Issue Details (click to expand)
File Line Issue
.github/workflows/reusable/cargo-deny.yml 28 Duplicate reusable workflow without removing original — the flattened reusable-cargo-deny.yml still exists alongside this nested copy, creating two identical files to maintain
Observation

The PR description confirms the duplicate is intentional: both files will be kept to support consumers using either path (reusable-cargo-deny.yml or reusable/cargo-deny.yml). This is a pragmatic CI-only fix with no application logic impact, but maintainership burden doubles.

Files Reviewed (1 file)
  • .github/workflows/reusable/cargo-deny.yml

Reviewed by step-3.7-flash-20260528 · 568,386 tokens

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S This PR changes 10-29 lines, ignoring generated files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant