Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions content/cli/lavaflow.md
Original file line number Diff line number Diff line change
Expand Up @@ -443,6 +443,8 @@ A reason your CLI doesn't know shows as `Other` with its code. When no
reviewer could run, the review reads `Review: error; no reviewer could run`,
followed by `Review stopped:` with the reason.

For an issue covered by an existing pull request, the `Fix:` block shows that pull request and its GitHub state.

The `Source:` line gives the commit's short SHA and where it came from:

| Shown | Meaning |
Expand Down
19 changes: 9 additions & 10 deletions content/platform/guides/lavaflow.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,8 @@ LavaFlow turns production errors into reviewed fixes.
5. **Pull request**: LavaFlow opens a pull request with the fix in the project's [linked repository](#link-a-repository).
6. **Review**: you review the pull request like any other, unless you let LavaFlow merge.
7. **Merge**: you merge it, or [let LavaFlow merge it](#merge-fixes) once LavaFlow's reviewers and the required checks pass.
8. **Deployed**: when a deployment Volcano confirmed has the fix goes live, LavaFlow [resolves the issue](#after-a-fix-merges).

LavaFlow finishes work on the pull request when it merges.

Volcano picks and runs the models, so there is no model or API key to set up.

Expand Down Expand Up @@ -1272,9 +1273,7 @@ New reasons may appear.

While merging is paused, a waiting merge gets `reason` `paused`. LavaFlow takes
a queued fix out of the merge queue, so it shows `waiting_for_checks`, and
queues it again when merging resumes. A fix that merged into a project that
doesn't deploy it automatically gets `reason` `manual_deploy`: deploy it to
ship the fix.
queues it again when merging resumes. LavaFlow records a successful merge as `merged`.

LavaFlow doesn't bill merges.

Expand Down Expand Up @@ -1307,10 +1306,11 @@ in your repository's Actions tab.

## After a fix merges

Once a fix's pull request merges, by you or by LavaFlow, LavaFlow watches the
resource's deployments from the repository, including deployments more than a
week later. Verification has bounded retries for each deployment; another
deployment starts fresh attempts. When LavaFlow verifies that a live deployment
The project's deployment workflow runs independently of the pull request.
After the merge, Volcano tracks the resource's deployments from the repository
to determine when to resolve the issue. This includes deployments more than a
week later. Verification has bounded retries for each deployment, and another
deployment starts fresh attempts. When Volcano verifies that a live deployment
includes the merge, it records the recurrence cutoff as the run's
`pull_request.deployed_at` and resolves the [issue](issues.md) as of that
moment, unless the error was seen after it. Where
Expand All @@ -1320,8 +1320,7 @@ code don't keep it open; `resolved_at` is 2 minutes after `deployed_at`. A
deployment whose
[reported commit](deployment-source.md#commit) has `verification: repository`
never counts, because Volcano didn't match its files against the commit.
[Resolve the issue](issues.md#resolve-or-ignore-an-issue) yourself, or deploy
the merge with a push to the repository.
You can also [resolve the issue yourself](issues.md#resolve-or-ignore-an-issue).

If the error happens again, the issue reopens, as any resolved issue does. For
an issue with `exception: true`, LavaFlow then starts a new run on it, no
Expand Down
Loading