Skip to content

fix: remove access token logging from examples - #246

Merged
volcano-staging[bot] merged 1 commit into
mainfrom
volcano/lavaflow/d8de43aa-f2ed-4388-aa77-b1b575a97861
Nov 20, 2026
Merged

volcano-staging[bot] merged 1 commit into
mainfrom
volcano/lavaflow/d8de43aa-f2ed-4388-aa77-b1b575a97861

Conversation

@volcano-staging

@volcano-staging volcano-staging Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Removes the four documentation examples that printed bearer access tokens (VOL-1831). The SDK signup examples now log whether a session was created, the refresh example logs the new session's expiry, and the REST signup example keeps only the user ID log. Authorization headers and SDK calls that use the token are unchanged.

Requested change. Implements the reporter's request.

Verification. Check the run details for recorded checks and this pull request for GitHub CI results. A test added or changed is not a claim that it passed.


An AI model wrote this change from a report and the repository files at a verified revision. LavaFlow will follow this PR through the repository's required checks and reviews, then merge it when they're satisfied.

LavaFlow run d8de43aa-f2ed-4388-aa77-b1b575a97861. Run details.

Volcano LavaFlow run d8de43aa-f2ed-4388-aa77-b1b575a97861.
@volcano-staging volcano-staging Bot added the Volcano LavaFlow Opened by Volcano LavaFlow label Nov 20, 2026
@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@volcano-staging volcano-staging Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LavaFlow is reviewing this draft at b143576. Findings appear inline where the pull-request diff permits. See the run details for the complete review.

@volcano-staging
volcano-staging Bot marked this pull request as ready for review November 20, 2026 00:01
@github-actions

Copy link
Copy Markdown
Contributor

AI review: no P0-P2 findings

Reviewed b143576. Run log

This PR edits three docs pages so the JavaScript examples stop printing access tokens. The SDK signup examples now log whether a session was created, the refresh example logs the session's expires_in (the same call content/sdk/js/authentication.md already shows), and the REST signup example keeps only the user ID log. The change is low risk: only code samples in docs change, no SDK or API behaviour changes, and the format contract still holds.

Not checked: The AI review read the diff, the code, and the PR's text; it ran no tests or builds and read nothing outside this repository.

Human review: not needed

@volcano-staging
volcano-staging Bot added this pull request to the merge queue Nov 20, 2026
Merged via the queue into main with commit a63228f Nov 20, 2026
29 of 30 checks passed
@volcano-staging
volcano-staging Bot deleted the volcano/lavaflow/d8de43aa-f2ed-4388-aa77-b1b575a97861 branch November 20, 2026 00:07
@volcano-staging

Copy link
Copy Markdown
Contributor Author

LavaFlow merged this fix. The project doesn't deploy it automatically; deploy it to ship the fix.

LavaFlow run d8de43aa-f2ed-4388-aa77-b1b575a97861.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Volcano LavaFlow Opened by Volcano LavaFlow

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant