Skip to content

fix: remove access token logging from examples - #243

Open
volcano-staging[bot] wants to merge 1 commit into
mainfrom
volcano/lavaflow/2702e3bc-ee90-471d-9ba2-ccfa02d592fc
Open

volcano-staging[bot] wants to merge 1 commit into
mainfrom
volcano/lavaflow/2702e3bc-ee90-471d-9ba2-ccfa02d592fc

Conversation

@volcano-staging

@volcano-staging volcano-staging Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Summary

For VOL-1831: documentation examples no longer print access tokens or whole session objects, which contain the access and refresh tokens. Each example now logs whether a session is present or a plain refresh message, or simply drops the token log. The tokens are still used in Authorization headers and SDK calls as before. The changed pages are the databases quick start, the authentication quick start, the authentication SDK refresh example and the JavaScript SDK error-handling guide.

Requested change. Implements the reporter's request.

Choices to confirm. This fix decides behavior beyond stopping the error. Read each choice with volcano cloud lavaflow show 2702e3bc-ee90-471d-9ba2-ccfa02d592fc --json and confirm it before you merge.

Verification. Check the run details for recorded checks and this pull request for GitHub CI results. A test added or changed is not a claim that it passed.


An AI model wrote this change from a report and the repository files at a verified revision. LavaFlow will follow this PR through the repository's required checks and reviews, then merge it when they're satisfied.

LavaFlow run 2702e3bc-ee90-471d-9ba2-ccfa02d592fc. Run details.

Volcano LavaFlow run 2702e3bc-ee90-471d-9ba2-ccfa02d592fc.
@volcano-staging volcano-staging Bot added the Volcano LavaFlow Opened by Volcano LavaFlow label Nov 19, 2026
@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@volcano-staging volcano-staging Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LavaFlow is reviewing this draft at 8826c98. Findings appear inline where the pull-request diff permits. See the run details for the complete review.

@volcano-staging
volcano-staging Bot marked this pull request as ready for review November 19, 2026 19:19
@github-actions

Copy link
Copy Markdown
Contributor

AI review: no P0-P2 findings

Reviewed 8826c98. Run log

This PR changes four docs pages so their JavaScript examples stop printing access tokens or whole session objects. Where a session was logged, the examples now log Boolean(session) or a plain message. The change is docs-only and low-risk, and every edited snippet still reads correctly in context.

🟣 Pre-existing

  • content/platform/authentication/quickstart.md:48 Sign-up quick starts read user.id from a sign-up that the SDK docs say returns no user

Not checked: The AI review read the diff, the code, and the PR's text; it ran no tests or builds and read nothing outside this repository.

Human review: not needed

@@ -46,7 +46,7 @@ if (error) {
}

console.log('User created:', user.id);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟣 Pre-existing: Sign-up quick starts read user.id from a sign-up that the SDK docs say returns no user

content/sdk/js/authentication.md:47 and content/sdk/js/error-handling.md:59 say signUp is session-less: it returns no user and no session unless signInWhenAllowed: true is passed. Two examples call signUp without that option and then read user.id: this page (line 48) and content/platform/databases/quick-start.md:56. A reader who copies either example would get a TypeError on user.id. This page's sample response (lines 54-67) also shows a populated session. This PR edits the line right below and neither introduces nor worsens the problem. The fix is to pass signInWhenAllowed: true or add a separate signIn step, as the SDK guide does.

Found by claude-opus-5-5

@volcano-staging

Copy link
Copy Markdown
Contributor Author

LavaFlow stopped: missing GitHub access.

Check Volcano's GitHub App permissions and the project owner's push access. Review and merge or close this PR yourself.

LavaFlow run 2702e3bc-ee90-471d-9ba2-ccfa02d592fc.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Volcano LavaFlow Opened by Volcano LavaFlow

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant