Skip to content

fix: remove access token logging from examples - #241

Closed
volcano-staging[bot] wants to merge 1 commit into
mainfrom
volcano/lavaflow/6fe9459e-bc4a-448f-853e-0090edae9ae4
Closed

volcano-staging[bot] wants to merge 1 commit into
mainfrom
volcano/lavaflow/6fe9459e-bc4a-448f-853e-0090edae9ae4

Conversation

@volcano-staging

@volcano-staging volcano-staging Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Refs VOL-1831. Code examples in the platform auth quickstart, the Volcano SDK guide, the databases quick start and the JS SDK error-handling guide no longer print access tokens or whole session objects, which hold access and refresh tokens. They now log a user ID or a refresh success message, and keep using the token in Authorization headers and SDK calls.

Requested change. Implements the reporter's request.

Choices to confirm. This fix decides behavior beyond stopping the error. Read each choice with volcano cloud lavaflow show 6fe9459e-bc4a-448f-853e-0090edae9ae4 --json and confirm it before you merge.

Reviewer observations. LavaFlow's reviewers left an observation that doesn't hold this fix. Read them with volcano cloud lavaflow show 6fe9459e-bc4a-448f-853e-0090edae9ae4 --json.

Verification. Check the run details for recorded checks and this pull request for GitHub CI results. A test added or changed is not a claim that it passed.


An AI model wrote this change from a report and the repository files at a verified revision. LavaFlow will follow this PR through the repository's required checks and reviews, then merge it when they're satisfied.

LavaFlow run 6fe9459e-bc4a-448f-853e-0090edae9ae4. Run details.

Volcano LavaFlow run 6fe9459e-bc4a-448f-853e-0090edae9ae4.
@volcano-staging volcano-staging Bot added the Volcano LavaFlow Opened by Volcano LavaFlow label Nov 19, 2026
@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@volcano-staging volcano-staging Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LavaFlow is reviewing this draft at a2376c3. Findings appear inline where the pull-request diff permits. See the run details for the complete review.

@volcano-staging
volcano-staging Bot marked this pull request as ready for review November 19, 2026 18:15
@github-actions

Copy link
Copy Markdown
Contributor

AI review: no P0-P2 findings

Reviewed a2376c3. Run log

Docs-only change: four JavaScript examples (platform auth quickstart, the Volcano SDK guide, the databases quick start and the JS SDK error-handling page) no longer print access tokens or whole session objects. They now log the user ID or how long the refreshed session lasts. Both replacements use fields the other docs pages already describe: session.expires_in from refreshSession() and data.session?.user?.id from getSession(). A search of content/ finds no other example that logs a token. Low risk.

Not checked: The AI review read the diff, the code, and the PR's text; it ran no tests or builds and read nothing outside this repository.

Human review: not needed

@swkeever swkeever closed this Nov 19, 2026
@volcano-staging

Copy link
Copy Markdown
Contributor Author

LavaFlow stopped and won't merge this fix. A person took it over by drafting it, closing it, or moving it to another branch.

LavaFlow run 6fe9459e-bc4a-448f-853e-0090edae9ae4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Volcano LavaFlow Opened by Volcano LavaFlow

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants