fix(gateway): clarify DB-less license priority#5598
Open
STARRY-S wants to merge 1 commit into
Open
Conversation
👷 Deploy request for kongdeveloper pending review.Visit the deploys page to approve it
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR clarifies license source precedence in DB-less/declarative scenarios, specifically that runtime-applied licenses override KONG_LICENSE_DATA (which is only read at startup), and documents the behavior on both the Gateway License entity page and the KIC license page.
Changes:
- Add an info callout to the KIC license doc explaining precedence between
KongLicenseand a staticKONG_LICENSE_DATA-backed Secret. - Add an info callout to the Gateway License entity doc clarifying that DB-less/declarative config can override
KONG_LICENSE_DATAat runtime, including mention ofKongLicense. - Remove an extraneous trailing
|at the end of the Gateway License entity doc.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| app/kubernetes-ingress-controller/license.md | Adds an info callout about KongLicense precedence vs KONG_LICENSE_DATA when using a static license Secret. |
| app/_gateway_entities/license.md | Adds an info callout clarifying DB-less/declarative runtime override behavior and cleans up a stray trailing character at EOF. |
In DB-less/declarative mode, a license pushed via POST /config overrides KONG_LICENSE_DATA at runtime. Documented on the Gateway and KIC license pages.
448bb12 to
2439598
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In DB-less/declarative mode, a license pushed via POST /config overrides KONG_LICENSE_DATA at runtime. Documented on the Gateway and KIC license pages.
Fixes FTI-7253
Preview Links
Checklist
descriptionentry in frontmatter.