We auto create role by jplam123 · Pull Request #244 · KoalaBotUK/KoalaBot

jplam123 · 2021-08-06T13:13:34Z

Summary

Checklist

This PR fixes an issue.
This PR adds something new (e.g. new method or parameters).
This PR is a breaking change (e.g. methods or parameters removed/renamed)
This PR is not a code change (e.g. documentation, README, ...)

Have you tested the changes? (pytest & dpytest)
Have you followed PEP-8 for naming and styling?
Has your code been properly documented with RestructuredText docstrings?
Have you added your changes to CHANGELOG.md under the [Unreleased] heading?
If your code added new bot commands, have you updated documentation.json?

All of this code is your own, or follows the author repo's licence.

Signed-off-by: Jonathan <jplam12345@gmail.com>

codecov · 2021-08-06T13:15:18Z

Codecov Report

Merging #244 (87dfcf2) into master (29abb7b) will decrease coverage by 0.12%.
The diff coverage is 78.35%.

@@            Coverage Diff             @@
##           master     #244      +/-   ##
==========================================
- Coverage   82.53%   82.41%   -0.13%     
==========================================
  Files          27       27              
  Lines        6534     6630      +96     
==========================================
+ Hits         5393     5464      +71     
- Misses       1141     1166      +25

Flag	Coverage Δ
unittests	`82.41% <78.35%> (-0.13%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
cogs/Verification.py	`65.34% <63.79%> (-0.37%)`	⬇️
tests/test_Verification.py	`100.00% <100.00%> (ø)`
cogs/TwitchAlert.py	`58.06% <0.00%> (-0.76%)`	⬇️
cogs/Voting.py	`61.91% <0.00%> (-0.08%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29abb7b...87dfcf2. Read the comment docs.

lgtm-com · 2021-08-06T13:31:43Z

This pull request introduces 2 alerts when merging cc977eb into 29abb7b - view on LGTM.com

new alerts:

1 for Unused local variable
1 for Redundant assignment

Signed-off-by: Jonathan <jplam12345@gmail.com>

lgtm-com · 2021-08-06T13:54:12Z

This pull request introduces 1 alert when merging 19fbbe1 into 29abb7b - view on LGTM.com

new alerts:

1 for Redundant assignment

Signed-off-by: Jonathan <jplam12345@gmail.com>

lgtm-com · 2021-08-06T14:09:33Z

This pull request introduces 1 alert when merging 2a09754 into 29abb7b - view on LGTM.com

new alerts:

1 for Redundant assignment

Signed-off-by: Jaddison011 <ja3g20@soton.ac.uk>

lgtm-com · 2021-08-06T14:38:53Z

This pull request introduces 1 alert when merging 6075450 into 29abb7b - view on LGTM.com

new alerts:

1 for Redundant assignment

lgtm-com · 2021-08-06T14:53:50Z

This pull request introduces 1 alert when merging 4df82a6 into 29abb7b - view on LGTM.com

new alerts:

1 for Redundant assignment

Signed-off-by: Jonathan <jplam12345@gmail.com>

…aBot into WEAutoCreateRole Signed-off-by: Jonathan <jplam12345@gmail.com>

lgtm-com · 2021-08-06T15:09:39Z

This pull request introduces 1 alert when merging 87dfcf2 into 29abb7b - view on LGTM.com

new alerts:

1 for Redundant assignment

Kaspiaan · 2021-08-08T03:14:16Z

cogs/Verification.py

    return result or (str(ctx.author) == KoalaBot.TEST_USER and KoalaBot.is_dpytest)

+
+def check_if_role_exists(guild, university):


Please add a docstring above this, even though it's self explanitory it's still worth having one

Kaspiaan · 2021-08-08T03:15:32Z

cogs/Verification.py

        self.DBManager.db_execute_commit(non_verified_table)
        self.DBManager.db_execute_commit(role_table)
        self.DBManager.db_execute_commit(re_verify_table)
+        drop_universities = "DROP TABLE Universities"


Just wondering why you drop the table before re-creating it each time?

Kaspiaan · 2021-08-08T03:17:57Z

cogs/Verification.py

        """
+        role = role
+        if not suffix:
+            await ctx.send("hi")


Also just wondering the point in this considering the case of suffix not beign provided would be caught afterwards anyway

Kaspiaan · 2021-08-08T03:25:11Z

cogs/Verification.py

+            role_id = f"<@&{str(role.id)}>"
+            await self.verify_university(ctx, email_suffix, role_id, university)
+
+    def insert_university_csv(self):


Please include a test for this if possible

Kaspiaan

Please make sure all methods have tests where possible, also noticed some stuff I'm not sure the use behind such as dropping the table each time the init is called regardless of anythign else, also a random ctx.send("hi"), not sure if that was left over from debugging or I might be missing something.

Kaspiaan · 2021-08-08T03:30:39Z

To add onto the testing portion, have a look at the automated tests made on python 3.7 as some of the new tests failed. Another issue is the code coverage but this can be rectified by ensuring your tests cover as much as possible.

jplam123 added 6 commits August 5, 2021 15:34

feat: added tables for university emails

87fd4e5

Signed-off-by: Jonathan <jplam12345@gmail.com>

fixed: tuple issue with insertion and selection of database

ad903b2

Signed-off-by: Jonathan <jplam12345@gmail.com>

feat: added university roles, and enabled Verification for them

7273114

Signed-off-by: Jonathan <jplam12345@gmail.com>

added: two tests

537f6cd

Signed-off-by: Jonathan <jplam12345@gmail.com>

fixed: readding of universities

98cb497

Signed-off-by: Jonathan <jplam12345@gmail.com>

Merge remote-tracking branch 'origin/master' into WEAutoCreateRole

cc977eb

jplam123 linked an issue Aug 6, 2021 that may be closed by this pull request

Auto Create University Roles #198

Open

jplam123 assigned jplam123 and Jaddison011 Aug 6, 2021

Added: test to improve coverage

19fbbe1

Signed-off-by: Jonathan <jplam12345@gmail.com>

altered test to use verificaiton and added more asserts

2a09754

Signed-off-by: Jonathan <jplam12345@gmail.com>

Jaddison011 added 2 commits August 6, 2021 15:20

Added insert_university_csv test

2fa707b

Signed-off-by: Jaddison011 <ja3g20@soton.ac.uk>

Added insert_university_csv test

6075450

Signed-off-by: Jaddison011 <ja3g20@soton.ac.uk>

Jaddison011 added 2 commits August 6, 2021 15:39

Reverting previous change

10d8d3d

Removed insert_university_csv test due to error

4df82a6

jplam123 added 2 commits August 6, 2021 15:54

in inner loop now

3eb4710

Signed-off-by: Jonathan <jplam12345@gmail.com>

Merge branch 'WEAutoCreateRole' of https://github.com/KoalaBotUK/Koal…

87dfcf2

…aBot into WEAutoCreateRole Signed-off-by: Jonathan <jplam12345@gmail.com>

jplam123 marked this pull request as ready for review August 6, 2021 14:56

Kaspiaan reviewed Aug 8, 2021

View reviewed changes

Kaspiaan requested changes Aug 8, 2021

View reviewed changes

Kaspiaan assigned Kaspiaan and unassigned jplam123 and Jaddison011 Oct 18, 2021

VirajShah18 marked this pull request as draft November 9, 2021 00:39

		return result or (str(ctx.author) == KoalaBot.TEST_USER and KoalaBot.is_dpytest)


		def check_if_role_exists(guild, university):

Conversation

jplam123 commented Aug 6, 2021

Summary

Checklist

Uh oh!

codecov bot commented Aug 6, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

lgtm-com bot commented Aug 6, 2021

Uh oh!

lgtm-com bot commented Aug 6, 2021

Uh oh!

lgtm-com bot commented Aug 6, 2021

Uh oh!

lgtm-com bot commented Aug 6, 2021

Uh oh!

lgtm-com bot commented Aug 6, 2021

Uh oh!

lgtm-com bot commented Aug 6, 2021

Uh oh!

Kaspiaan Aug 8, 2021

Choose a reason for hiding this comment

Uh oh!

Kaspiaan Aug 8, 2021

Choose a reason for hiding this comment

Uh oh!

Kaspiaan Aug 8, 2021

Choose a reason for hiding this comment

Uh oh!

Kaspiaan Aug 8, 2021

Choose a reason for hiding this comment

Uh oh!

Kaspiaan left a comment

Choose a reason for hiding this comment

Uh oh!

Kaspiaan commented Aug 8, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov bot commented Aug 6, 2021 •

edited

Loading