Skip to content

Check performance etc. #8

Description

@KnutAM

Ferrite.reinit!(vals::NTuple{N,Ferrite.Values}, args...) where N = foreach(v->reinit!(v, args...), vals)
Ferrite.reinit!(vals::NamedTuple, args...) = foreach(v->reinit!(v, args...), vals)

When working with https://github.com/Ferrite-FEM/Ferrite.jl/tree/kam/CellMultiValues it seems like this code pattern could allocate and be slow. Consider changing to map (and also change the name to avoid type piracy).

Also, the dispatch of NTuple might not work for different values, hence it should just be Tuple (which is ok once it has a separate name anyways)
Alternatively, support only the CellMultiValues once they are completed.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions