[Blade] Form Sectioning + UI Nits #288
Conversation
| }, | ||
| }); | ||
|
|
||
| // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment, @typescript-eslint/no-unsafe-call, @typescript-eslint/no-unsafe-member-access |
There was a problem hiding this comment.
wanted to shut up LSP without reloading and losing my place. its irrelevant now, just deleted
| }); | ||
| }), | ||
|
|
||
| renameSection: permProcedure |
There was a problem hiding this comment.
Shouldnt this be in update cause its ID based
There was a problem hiding this comment.
if ur referring to updateFormSection, that doesn't update a section. what it does is it takes a form, and moves it to a new section. now that i say it out loud, that logic couldve gone into updateForm as well but i was separation of concerns brained
packages/api/src/routers/forms.ts
Outdated
| }); | ||
| if (sectionToDelete) { | ||
| await db | ||
| .delete(FormSectionRoles) |
There was a problem hiding this comment.
Maybe do this with a cascade instead?
|
|
||
| const userRoleIds = new Set(userRoles.map((r) => r.roleId)); | ||
|
|
||
| const hasAllRoles = input.roleIds.every((roleId) => |
There was a problem hiding this comment.
Idk if theres a set AND in JS but if there itd be cool to use it here
| allowResubmission: t.boolean().notNull().default(false), | ||
| formData: t.jsonb().notNull(), | ||
| formValidatorJson: t.jsonb().notNull(), | ||
| section: t.varchar({ length: 255 }).notNull().default("General"), |
There was a problem hiding this comment.
Why do you have both name and ID
There was a problem hiding this comment.
don't want to display an ID in the UI
DGoel1602
left a comment
DGoel1602
left a comment
There was a problem hiding this comment.
lgtm lets just make a note to change the section name storage in forms
Why
Because not everyone with READ_FORMS or EDIT_FORMS should see every form
What
Adds a form tab style sectioning, where each tab is configured with a role. Users can only create tabs for roles that they currently have. Then forms remain hidden. Editing a form without access will also redirect you, and deleting a tab moves all of its forms into the open access "General" tab. Also did some minor UI fixes (like having back buttons in all of our form pages...)
Test Plan