Repository navigation
Conversation
Keep the front reachable after flipping to a usable back face, even when every front slice is disabled. Addresses KnifeLemon#1374.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
A donut can show a front face with every slice disabled and still flip to a usable back face. Previously the back then refused to flip to the front, because it required an enabled slice there. Keep the already-shown front reachable as long as it has slices, while still requiring a usable back when flipping from the front.
Addresses one reproducible case related to #1374; the reporter's engine status is not yet known.
Type of change
How was it tested?
dotnet format Filee.slnx --verify-no-changes --no-restoreChecklist