WIP: feat: support trame client_type="react" - #98
Closed
patrickoleary wants to merge 1 commit into
Closed
patrickoleary wants to merge 1 commit into
patrickoleary wants to merge 1 commit into
Conversation
Add react-components/ (TypeScript) providing the VtkLocal component for the native React client that ships with trame-client, mirroring vue-components/: same wasm runtime/remote-session management (shared window registries + trame.refs.vtkWASM), scene sync through the vtklocal.get.* RPCs, camera/listener observers, progress overlay and the imperative surface (update, resetCamera, invoke, evalStateExtract, startWebXR, ...) through refs for server js_call. src/utils.js is shared verbatim with vue-components. The module setup selects the client bundle by server.client_type (trame_vtklocal.umd.js + vue_use, or trame_vtklocal_react.umd.cjs + react_use); CI builds both bundles.
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add react-components/ (TypeScript) providing the VtkLocal component for
the native React client that ships with trame-client, mirroring
vue-components/: same wasm runtime/remote-session management (shared
window registries + trame.refs.vtkWASM), scene sync through the
vtklocal.get.* RPCs, camera/listener observers, progress overlay and the
imperative surface (update, resetCamera, invoke, evalStateExtract,
startWebXR, ...) through refs for server js_call. src/utils.js is shared
verbatim with vue-components.
The module setup selects the client bundle by server.client_type
(trame_vtklocal.umd.js + vue_use, or trame_vtklocal_react.umd.cjs +
react_use); CI builds both bundles.