Skip to content

feat(eagerSync): remove eager synchronization - #96

Merged
jourdain merged 1 commit into
masterfrom
remove-eager-sync
Aug 27, 2026
Merged

jourdain merged 1 commit into
masterfrom
remove-eager-sync

Conversation

@jourdain

Copy link
Copy Markdown
Collaborator

No description provided.

@codecov

codecov Bot commented Aug 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.28%. Comparing base (babdde9) to head (1922164).
⚠️ Report is 64 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #96      +/-   ##
==========================================
+ Coverage   56.17%   58.28%   +2.10%     
==========================================
  Files          12       12              
  Lines         518      489      -29     
==========================================
- Hits          291      285       -6     
+ Misses        227      204      -23     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jourdain
jourdain requested a review from jspanchu August 27, 2026 16:47
@jourdain
jourdain merged commit a45c243 into master Aug 27, 2026
6 checks passed
@jourdain
jourdain deleted the remove-eager-sync branch August 27, 2026 16:59
@bourdaisj

Copy link
Copy Markdown
Contributor

@jourdain I am curious about this change? What has motivated it?

@jspanchu

Copy link
Copy Markdown
Member

the batched-fetch of state and blobs added in #89 makes this unnecessary.

The javascript side api like RemoteSession.patchState which this relied upon was removed in vtk-wasm library.

@jourdain

Copy link
Copy Markdown
Collaborator Author

@jspanchu is spot on, no real need for eagerSync anymore. The new batch fetching is providing even more flexibility and performance than before by making a better use of the network.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants