feat(eagerSync): remove eager synchronization - #96
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #96 +/- ##
==========================================
+ Coverage 56.17% 58.28% +2.10%
==========================================
Files 12 12
Lines 518 489 -29
==========================================
- Hits 291 285 -6
+ Misses 227 204 -23 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jourdain
force-pushed
the
remove-eager-sync
branch
from
August 27, 2026 16:46
1922164 to
b0fc280
Compare
jourdain
force-pushed
the
remove-eager-sync
branch
from
August 27, 2026 16:46
b0fc280 to
7cc8949
Compare
jspanchu
approved these changes
Aug 27, 2026
Contributor
|
@jourdain I am curious about this change? What has motivated it? |
Member
|
the batched-fetch of state and blobs added in #89 makes this unnecessary. The javascript side api like |
Collaborator
Author
|
@jspanchu is spot on, no real need for eagerSync anymore. The new batch fetching is providing even more flexibility and performance than before by making a better use of the network. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.