Added a simple darkmode functionality settings => theme#388
Open
spogo1312 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #365
Changes proposed in this pull request:
• Added dark theme support with UI toggle in Settings window (requires restart to apply)
• Implemented Theme enum (Light/Dark) and persistence in ApplicationSettings
• Created centralized theme infrastructure:
• Themes/AppTheme.cs - Code-side theme provider for custom-drawn UI elements
• Themes/Light.xaml and Themes/Dark.xaml - XAML resource dictionaries with theme colors
• Made log view theme-aware:
• Log background, alternating row colors, and text colors adapt to selected theme
• Line numbers and data source indicators use themed colors
• Selected/unfocused rows now have readable contrast in both themes
• Themed menu dropdowns (File/Edit/View) with appropriate colors for both light and dark modes
• Themed scrollbars with visible contrast in dark mode
• Updated main window and settings panel backgrounds to respect theme selection
Any expected problems concerning backwards compatibility of existing plugins?
No - The theme system uses existing WPF resource infrastructure and does not modify plugin interfaces or APIs.
Any expected problems concerning backwards compatibility of existing user settings?
No - The new theme attribute in settings XML defaults to Light if not present, preserving existing user experience. Existing settings files will automatically migrate to light theme on first load.
Does this break existing user workflows?
No - Light theme remains the default. Users can opt-in to dark theme via Settings > Window > Theme. The theme change requires an application restart (clearly indicated in the UI).