Nom 37/feature/mike integration#8
Open
AdamLucka wants to merge 19 commits into
Open
Conversation
…Integration # Conflicts: # app/build.gradle # app/src/main/AndroidManifest.xml # app/src/main/java/nomic/ui/MainActivity.kt # app/src/main/java/nomic/ui/fragments/MainFragment.kt # app/src/main/res/layout/activity_main.xml
…into Nom-37/Feature/MikeIntegration
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #8 +/- ##
=============================================
- Coverage 44.91% 30.98% -13.93%
- Complexity 16 27 +11
=============================================
Files 10 15 +5
Lines 118 284 +166
Branches 8 33 +25
=============================================
+ Hits 53 88 +35
- Misses 65 189 +124
- Partials 0 7 +7
☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR accomplish?
Definition of Done
The User Story has and passes all tests with consistent, reproducible results. (80% coverage)
The User Story conforms to the style guide.
The User Story contains a basic level of documentation (KDocs, comments, clear variable names, etc.)
The User Story passes the following checklist from a reviewer:
File structure is maintained (e.g., a component goes in the Components folder)
Confirm that the tests are actually testing the code
Code contains comments that provide a basic understanding of the code
Acceptance Criteria
What are the acceptance criteria?