Skip to content

Fix parsing for ** exponent #418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SuixiongTay wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix parsing for ** exponent #418

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/pyEQL/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ def _translate_pint_quantity(amount: str):
if isinstance(amount, Quantity):
return amount.magnitude, str(amount.units)

match = re.match(r"^\s*([+-]?\d*\.?\d+(?:[eE][+-]?\d+)?)\s*(.*)$", amount)
match = re.match(r"^\s*([0-9eE+\-*/().]+)\s*(.*)$", amount)

if match is None:
return amount
Expand Down
3 changes: 3 additions & 0 deletions tests/test_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,10 @@ def test_create_water_substance():


def test_translate_pint_quantity():
import pytest # noqa: PLC0415

assert _translate_pint_quantity("5mol/kg") == (5, "mol/kg")
assert _translate_pint_quantity("0.1g/L") == (0.1, "g/L")
assert _translate_pint_quantity("1ppb") == (1, "ug/L")
assert _translate_pint_quantity("0.01 ppm") == (0.01, "mg/L")
assert _translate_pint_quantity("10**(-10.3) mol/L") == pytest.approx((5.011872336e-11, "mol/L"))
Loading