Skip to content

Only running coverage on ubuntu#408

Merged
rkingsbury merged 1 commit into
mainfrom
vb/cov
May 27, 2026
Merged

Only running coverage on ubuntu#408
rkingsbury merged 1 commit into
mainfrom
vb/cov

Conversation

@vineetbansal
Copy link
Copy Markdown
Collaborator

@vineetbansal vineetbansal commented May 26, 2026

Looks like all runners in testing-pinned workflow run tests with coverage, but then discard the coverage results anyway. This is not a fix for the CI issue seen in PR #397, but should fix it anyway ;)

testing.yml still runs with coverage and uploads to codecov, like before.

@vineetbansal vineetbansal requested a review from rkingsbury May 26, 2026 22:55
@codecov
Copy link
Copy Markdown

codecov Bot commented May 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.19%. Comparing base (bcd9bd6) to head (56dce99).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #408   +/-   ##
=======================================
  Coverage   86.19%   86.19%           
=======================================
  Files          14       14           
  Lines        1840     1840           
  Branches      318      318           
=======================================
  Hits         1586     1586           
  Misses        209      209           
  Partials       45       45           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rkingsbury rkingsbury added the github_actions Pull requests that update GitHub Actions code label May 27, 2026
@rkingsbury rkingsbury merged commit 9094d2a into main May 27, 2026
17 checks passed
@rkingsbury
Copy link
Copy Markdown
Member

Thanks @vineetbansal !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github_actions Pull requests that update GitHub Actions code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants