Benchmarking visualization#399
Open
YitongPan1 wants to merge 3 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #399 +/- ##
=======================================
Coverage 86.21% 86.21%
=======================================
Files 14 14
Lines 1842 1842
Branches 318 318
=======================================
Hits 1588 1588
Misses 209 209
Partials 45 45 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rkingsbury
requested changes
May 15, 2026
Member
rkingsbury
left a comment
There was a problem hiding this comment.
Thank you @YitongPan1 , it will be great to have a built-in way to generate these types of plots. Please modify a few things:
- create a new folder
benchmarksunder/src/pyEQLand move all your data files into it - rename
Benchmarking_plotbenchmark(.py) and keep it in thesrc/pyEQLdirectory. (another python convention - module names are always lowercase) - Include bibliographic information for the specific CRC tables you used in the data files. You can probably do this as the first line of your .CSVs, which you can then tell
pandasto skip when loading the file - Add a docstring for the user-facing function
benchmark - prefix any private functions (not intended for direct use by end user) with a
_. Sofilter_df->_filter_df. (Yet another python convention) - Add a page under
docsthat shows plots for each of the salts you have and includes the reference information. Make a separate subfolder calledplotsunder docs to save the images. (This item can be a separate PR if you prefer)
Member
|
Also remember to lint by running |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Major changes:
supports #252
Example usage:
Todos
If this is work in progress, what else needs to be done?
NaCl,KCl,CaCl2,MgCl2,Na2SO4,K2SO4, andMgSO4;Checklist
ruff. (For guidance in fixing rule violates, see rule list)mypy.Tip: Install
pre-commithooks to auto-check types and linting before every commit: