-
Notifications
You must be signed in to change notification settings - Fork 24
Feature: Saturation Index Retrieval and Plotting #395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
SuixiongTay
wants to merge
29
commits into
KingsburyLab:main
Choose a base branch
from
SuixiongTay:scaling_sat_index
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
3cb64b3
get_sat_idx
0a334fd
correct halite naming
8b37b29
Merge branch 'main' of https://github.com/SuixiongTay/pyEQL into scal…
4a2891a
Merge branch 'main' of https://github.com/SuixiongTay/pyEQL into scal…
c782684
add monkeypatch for plt
f17b807
Update test_solution.py
YitongPan1 7a63484
Update test_solution.py
YitongPan1 65a1384
Update test_solution.py
YitongPan1 5871b37
Update test_solution.py
YitongPan1 30964be
added corrections
045085a
Merge branch 'main' of https://github.com/SuixiongTay/pyEQL into scal…
114a569
added corrections
ff895d1
Merge branch 'scaling_sat_index' of https://github.com/SuixiongTay/py…
9baf96c
added engine parameterize test
303e0d8
Update test_solution.py
YitongPan1 8abffd4
Update test_solution.py
YitongPan1 693e730
Update test_solution.py
YitongPan1 562e307
Update test_solution.py
YitongPan1 ecc71cd
Update test_solution.py
YitongPan1 3d4364f
Update test_solution.py
YitongPan1 9d51041
Merge branch 'main' into scaling_sat_index
rkingsbury 8bbf078
solution.py correction
39210d2
small correction
992bb32
small correction
b0ade6d
small corrections
2f5e5fa
removed checkpoints
97bcb40
Merge branch 'main' into scaling_sat_index
rkingsbury 6cd4529
trigger ci
d68c80f
Merge branch 'main' into scaling_sat_index
rkingsbury File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.