WIP - Migrate Pourbaix workflow to pyEQL v1.5.0#369
Conversation
|
Hi @rkingsbury , I noticed the Should I target this PR against the |
pyEQL v1.5.0pyEQL v1.5.0
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #369 +/- ##
===========================================
- Coverage 86.21% 68.99% -17.22%
===========================================
Files 14 18 +4
Lines 1842 3116 +1274
Branches 319 552 +233
===========================================
+ Hits 1588 2150 +562
- Misses 209 883 +674
- Partials 45 83 +38 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hi @SuixiongTay , sorry I somehow missed your comment from 4/1. I've rebased your changes in the |
pyEQL v1.5.0pyEQL v1.5.0
Description
This PR migrates the previous
pourbaixtopourbaix_pyEQL_v1.5branch.Content
pourbaix_api.pypourbaix_diagram.pyion.pycompatibility.pyMP2020Compatibility.yamlmpr_reference_ion_database.jsonpourbaix_test_data.jsonpymatgentest_pourbaix_api.pytest_pourbaix_diagram.pyNote
emmet-coreusestyping.NotRequiredwhich was introduced in python3.11.pytest.importskipis used to skip through python3.10to avoid the error.Addressing #368