fix(model-stats): publish benchmarks for new models#4051
Open
lambertjosh wants to merge 2 commits into
Open
Conversation
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Executive SummaryThe previously flagged Files Reviewed (6 files)
Previous Review Summary (commit 2baab6f)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit 2baab6f)Status: 1 Issue Found | Recommendation: Minor suggestion, safe to merge Executive SummaryClean refactor that extracts shared model identity logic and adds orphaned Terminal Bench promotion repair — the one concern is that Overview
Issue Details (click to expand)SUGGESTION
Files Reviewed (6 files)
Reviewed by deepseek-v4-pro-20260423 · 196,307 tokens Review guidance: REVIEW.md from base branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes an existing limitation in the terminal bench sync, which is that the core model stats data is not generated unless the model is recommended. Prior to this PR, the kilo bench data would not be added into the returned result for these models.
Since we do not want to limit kilo bench data to only recommended models, we need to also populate an initial model stats entry for these non-recommended models.
Changes
Verification
Visual Changes
Models that were not recommended now show.
Reviewer Notes
The reconciliation runs during regular model-eval syncs, so existing orphaned Terminal Bench rows are repaired without a one-off migration. Non-Terminal-Bench promotions continue to leave unknown models untouched.