Skip to content

feat: carry Kii v0.6 patches onto v0.7.3 - #23

Open
mattkii wants to merge 5 commits into
base/v0.7.3from
feat/fork-v0.7.3
Open

mattkii wants to merge 5 commits into
base/v0.7.3from
feat/fork-v0.7.3

Conversation

@mattkii

@mattkii mattkii commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

Description

Review the five Kii patches carried from the v0.6 fork onto cosmos/evm v0.7.3. This pull request targets base/v0.7.3 (c3ae9067), so the diff is those commits only.

The other v0.6 fork fixes (StateDB overflow and underflow guards, commit atomicity, locked-balance snapshot, gasCap, precompile gas, ERC20 and ICS-20 acks, Ledger coin type) are already in v0.7.3.

Brought from the v0.6 fork:

  • Refund unused EVM gas in the denom that was actually paid (ContextPaidFeesKey, capped by the amount paid).
  • Reject contract creation unless the account is empty or a plain BaseAccount (IsBaseAccountOrEmpty).
  • Skip non-20-byte accounts when mirroring balances, and reject a non-20-byte distribution withdraw address.
  • Use the sign-doc chain id for EIP-712 when it parses as a uint64.
  • Treat an already-known EVM tx as CheckTx success, and return ErrAlreadyKnown from SendRawTransaction.

After this is approved, tag the merged commit as the new fork line. main stays on the v0.6 fork (v0.6.2-fork.2) until then.

Kiichain will follow the v0.6.x → v0.7.0 migration guide on feat/evm-v0.7.3: bump Go 1.25, cosmos-sdk v0.54, cometbft v0.39, ibc-go v11, and geth 1.17; replace ExperimentalEVMMempool with Krakatoa; recopy the fee-abstraction EVM ante so it still sets ContextPaidFeesKey; drop x/precisebank; leave BlockSTM off for the first cut.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • tackled an existing issue or discussed with a team member
  • left instructions on how to review the changes
  • targeted base/v0.7.3 (v0.7.3). main is still the v0.6 fork and is not the review base

@mattkii mattkii mentioned this pull request Oct 5, 2026
3 tasks done
@coderabbitai

coderabbitai Bot commented Oct 5, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: e5f2e931-7f6c-439c-b0e1-ee1acdc60f3b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants