Skip to content

Mark superseded VK_KHR_surface commands as legacy#2763

Open
HildarTheDorf wants to merge 1 commit into
KhronosGroup:mainfrom
umbral-software:main
Open

Mark superseded VK_KHR_surface commands as legacy#2763
HildarTheDorf wants to merge 1 commit into
KhronosGroup:mainfrom
umbral-software:main

Conversation

@HildarTheDorf

@HildarTheDorf HildarTheDorf commented Jun 9, 2026

Copy link
Copy Markdown

Similar logic to legacy-gpdp2, only for the VK_KHR_surface extension.

(I started off wanting to write a bpa check for it, but since the legacy checks are auto-generated from vk.xml, this seems the correct place)

@CLAassistant

CLAassistant commented Jun 9, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@HildarTheDorf HildarTheDorf force-pushed the main branch 2 times, most recently from 14bc01b to 85ea25d Compare June 9, 2026 22:19
@HildarTheDorf

Copy link
Copy Markdown
Author

I'm guessing EXT should also be obsoleted by KHR, but that feels like something that should be done in a big "mark all EXTs that have KHR variants as legacy" PR?

@oddhack

oddhack commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

@cubanismo this is superficially an SI PR, but the underlying obsoletion issue can be brought up on the maintenance call.

@cubanismo

Copy link
Copy Markdown
Contributor

I'm guessing EXT should also be obsoleted by KHR

You mean vkGetPhysicalDeviceSurfaceCapabilities2EXT()? vkGetPhysicalDeviceSurfaceCapabilities2KHR() is not a promoted version of that function, and the EXT version exposes functionality the KHR does not, so it should not deprecate it.

VK_KHR_get_surface_capabilities isn't a real extension name, so you should probably pick a different title for the commit/PR, but otherwise, I think this looks OK.

@r-potter

Copy link
Copy Markdown
Contributor

2026-06-10 maintenance call: technically looks fine, but legacy/deprecation changes require main WG approval. Scheduled for next meeting.

@HildarTheDorf HildarTheDorf changed the title Mark VK_KHR_get_surface_capabilities commands as legacy Mark superseded VK_KHR_surface commands as legacy Jun 10, 2026
@HildarTheDorf

Copy link
Copy Markdown
Author

Fixed: Spelling error, PR/commit title
Unsure if this fail is related or not: https://github.com/KhronosGroup/Vulkan-Docs/actions/runs/27239585222/job/80462982256

@oddhack

oddhack commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Fixed: Spelling error, PR/commit title Unsure if this fail is related or not: https://github.com/KhronosGroup/Vulkan-Docs/actions/runs/27239585222/job/80462982256

It is not related. There's an error in a script in the repository that test comes from, and it is affecting all our CI runs until it's fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants