Merge 2.0.1 to main#13
Open
indrora wants to merge 11 commits into
Open
Conversation
Feat/pam extension support
There was a problem hiding this comment.
Pull request overview
This automated release merge brings v2.0.1 changes to main, primarily adding PAM secret-resolution support to the Kemp orchestrator jobs and refreshing supporting docs/assets and store-type creation scripts.
Changes:
- Add PAM secret resolution support for Management/Inventory jobs and update orchestrator extension dependency versions.
- Add store-type creation scripts for curl/kfutil/PowerShell and update docs (README + new SVG screenshots).
- Update release workflow starter action version and append v2.0.1 changelog entry.
Reviewed changes
Copilot reviewed 12 out of 17 changed files in this pull request and generated 13 comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/store_types/powershell/restmethod_create_store_types.ps1 | Adds PowerShell Invoke-RestMethod store-type creation script. |
| scripts/store_types/powershell/kfutil_create_store_types.ps1 | Adds PowerShell kfutil-based store-type creation script. |
| scripts/store_types/bash/kfutil_create_store_types.sh | Adds bash kfutil-based store-type creation script. |
| scripts/store_types/bash/curl_create_store_types.sh | Adds bash curl-based store-type creation script. |
| README.md | Documentation cleanup + updated store-type instructions and image references. |
| Kemp/PamUtilities.cs | Introduces helper for PAM secret resolution. |
| Kemp/Kemp.csproj | Updates package versions (including orchestrator extensions + Newtonsoft.Json). |
| Kemp/Jobs/Management.cs | Adds PAM resolution and reduces secret logging exposure. |
| Kemp/Jobs/Inventory.cs | Adds PAM resolution and reduces secret logging exposure. |
| Kemp.sln | Normalizes solution header formatting. |
| docsource/images/Kemp-custom-fields-store-type-dialog.svg | Adds SVG documentation asset. |
| docsource/images/Kemp-custom-field-ServerUseSsl-validation-options-dialog.svg | Adds SVG documentation asset. |
| docsource/images/Kemp-custom-field-ServerUseSsl-dialog.svg | Adds SVG documentation asset. |
| docsource/images/Kemp-basic-store-type-dialog.svg | Adds SVG documentation asset. |
| docsource/images/Kemp-advanced-store-type-dialog.svg | Adds SVG documentation asset. |
| CHANGELOG.md | Adds v2.0.1 entry noting PAM resolution support. |
| .github/workflows/keyfactor-release-workflow.yml | Updates reusable workflow reference (starter.yml v3 → v5) and secrets list. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+17
to
+18
| logger.LogDebug($"Attempting to resolve PAM eligible field {name}"); | ||
| return string.IsNullOrEmpty(key) ? key : resolver.Resolve(key); |
Comment on lines
+27
to
+31
| public IPAMSecretResolver _resolver; | ||
| public string ExtensionName => "Kemp"; | ||
| private ILogger _logger; | ||
|
|
||
| public Management(ILogger<Management> logger) | ||
| public Management(IPAMSecretResolver resolver) |
Comment on lines
+40
to
44
| _logger = LogHandler.GetClassLogger(this.GetType()); | ||
| _logger.MethodEntry(); | ||
|
|
||
| try | ||
| { |
Comment on lines
7
to
9
| using Microsoft.Extensions.Logging; | ||
| using Newtonsoft.Json; | ||
| using Org.BouncyCastle.Crypto; |
Comment on lines
+7
to
+8
| using Microsoft.Extensions.Logging; | ||
| using Newtonsoft.Json; |
| var certificatesResult = client.GetCertificates().Result; | ||
| var intermediateCertificates = client.GetIntermediateCertificates().Result; | ||
|
|
||
| //Debug Write Certificate List Response from Palo Alto |
| listSerializer.Serialize(listWriter, certificatesResult); | ||
| _logger.LogTrace($"Certificate List Result {listWriter}"); | ||
|
|
||
| //Debug Write Intermediate Certificate List Response from Palo Alto |
| try | ||
| { | ||
| _logger.MethodEntry(); | ||
| _logger.LogTrace($"Alias: {alias} Pem: {certPem} PrivateKey: *******"); |
| KEYFACTOR_AUTH_TOKEN="${KEYFACTOR_AUTH_TOKEN}" | ||
|
|
||
| echo "Creating store type: Kemp" | ||
| curl -s -X POST "https://${KEYFACTOR_HOSTNAME}/${KEYFACTOR_API_PATH}/CertificateStoreTypes" \ |
|
|
||
|
|
||
|
|
||
| TODO Overview is a required section |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge release-2.0 to main - Automated PR