fix(cli): include http response body in target errors#207
Merged
jithin23-kv merged 2 commits intoJul 21, 2026
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughChangesAgent HTTP error reporting
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
core/src/targets/agentTarget.ts (1)
236-246: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueExtract duplicate HTTP error handling into a helper function.
The error handling logic for non-OK responses is identical across both request paths. Consider extracting it into a helper function to keep the code DRY.
core/src/targets/agentTarget.ts#L236-L246: Replace with a call to the new helper function.core/src/targets/agentTarget.ts#L267-L278: Replace with a call to the new helper function.♻️ Proposed refactor
Define a helper function outside of
callHttp:async function handleHttpError(response: Response): Promise<string> { const errorBody = await response.text().catch(() => ""); const message = errorBody ? `Target returned HTTP ${response.status}: ${errorBody}` : `Target returned HTTP ${response.status}`; if (!isRetryableStatus(response.status)) { throw new TargetStopError(message); } return `ERROR: ${message}`; }Then, replace the duplicated blocks with calls to this helper:
- const errorBody = await res.text().catch(() => ""); - - const message = errorBody - ? `Target returned HTTP ${res.status}: ${errorBody}` - : `Target returned HTTP ${res.status}`; - // Non-retryable status (4xx except 429) - stop the run - if (!isRetryableStatus(res.status)) { - throw new TargetStopError(message); - } - // Retryable (5xx) - return error but continue - return `ERROR: ${message}`; + return await handleHttpError(res);- const errorBody = await res2.text().catch(() => ""); - - const message = errorBody - ? `Target returned HTTP ${res2.status}: ${errorBody}` - : `Target returned HTTP ${res2.status}`; - - // Non-retryable status (4xx except 429) - stop the run - if (!isRetryableStatus(res2.status)) { - throw new TargetStopError(message); - } - // Retryable (5xx) - return error but continue - return `ERROR: ${message}`; + return await handleHttpError(res2);🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@core/src/targets/agentTarget.ts` around lines 236 - 246, Extract the duplicated non-OK response handling from callHttp into a shared handleHttpError helper that reads the response body, builds the status message, throws TargetStopError for non-retryable statuses, and returns the retryable error string otherwise. Replace the handling blocks at core/src/targets/agentTarget.ts lines 236-246 and 267-278 with calls to this helper.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@core/src/targets/agentTarget.ts`:
- Around line 236-246: Extract the duplicated non-OK response handling from
callHttp into a shared handleHttpError helper that reads the response body,
builds the status message, throws TargetStopError for non-retryable statuses,
and returns the retryable error string otherwise. Replace the handling blocks at
core/src/targets/agentTarget.ts lines 236-246 and 267-278 with calls to this
helper.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 3a21eba5-b18b-4f6b-b5cc-761a93934c0f
📒 Files selected for processing (3)
core/src/targets/agentTarget.tsskills/agent-redteaming/opfor-setup/catalog.jsonskills/mcp-redteaming/opfor-setup/catalog.json
Karthik-EM
force-pushed
the
fix/capture-http-errors
branch
from
July 20, 2026 08:02
4023e85 to
b4ebc7c
Compare
Karthik-EM
force-pushed
the
fix/capture-http-errors
branch
from
July 20, 2026 08:19
b4ebc7c to
cfb39fd
Compare
There was a problem hiding this comment.
🧹 Nitpick comments (1)
core/src/targets/agentTarget.ts (1)
236-246: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winTruncate the error response to prevent log flooding.
Both code paths read the complete error response body into the error message without bounding its length. If the target endpoint is behind a proxy or WAF that returns a large HTML error page (e.g., for 502 or 504 errors), the resulting string can be excessively large and will flood the CLI output and application logs. Creating a helper function to truncate the response mitigates this risk and removes duplicate logic.
core/src/targets/agentTarget.ts#L236-L246: Replace this block with a call to a shared helper that truncates the text and handles the error flow.core/src/targets/agentTarget.ts#L267-L278: Replace this block with the same helper call.♻️ Proposed refactor
Add this helper outside the
tryblock (e.g., around line 208):const handleHttpError = async (response: Response): Promise<string> => { const rawBody = await response.text().catch(() => ""); const errorBody = rawBody.length > 1000 ? rawBody.slice(0, 1000) + "... (truncated)" : rawBody; const message = errorBody ? `Target returned HTTP ${response.status}: ${errorBody}` : `Target returned HTTP ${response.status}`; if (!isRetryableStatus(response.status)) { throw new TargetStopError(message); } return `ERROR: ${message}`; };Then replace both error-handling branches with a call to the helper:
- core/src/targets/agentTarget.ts#L236-L246:- const errorBody = await res.text().catch(() => ""); - - const message = errorBody - ? `Target returned HTTP ${res.status}: ${errorBody}` - : `Target returned HTTP ${res.status}`; - // Non-retryable status (4xx except 429) - stop the run - if (!isRetryableStatus(res.status)) { - throw new TargetStopError(message); - } - // Retryable (5xx) - return error but continue - return `ERROR: ${message}`; + return await handleHttpError(res);
- core/src/targets/agentTarget.ts#L267-L278:- const errorBody = await res2.text().catch(() => ""); - - const message = errorBody - ? `Target returned HTTP ${res2.status}: ${errorBody}` - : `Target returned HTTP ${res2.status}`; - - // Non-retryable status (4xx except 429) - stop the run - if (!isRetryableStatus(res2.status)) { - throw new TargetStopError(message); - } - // Retryable (5xx) - return error but continue - return `ERROR: ${message}`; + return await handleHttpError(res2);🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@core/src/targets/agentTarget.ts` around lines 236 - 246, Add a shared handleHttpError helper outside the try block in core/src/targets/agentTarget.ts, using a maximum 1000-character response body with a truncation suffix, preserving status messaging and TargetStopError behavior for non-retryable responses. Replace the duplicated error-handling blocks at core/src/targets/agentTarget.ts:236-246 and core/src/targets/agentTarget.ts:267-278 with calls to this helper.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@core/src/targets/agentTarget.ts`:
- Around line 236-246: Add a shared handleHttpError helper outside the try block
in core/src/targets/agentTarget.ts, using a maximum 1000-character response body
with a truncation suffix, preserving status messaging and TargetStopError
behavior for non-retryable responses. Replace the duplicated error-handling
blocks at core/src/targets/agentTarget.ts:236-246 and
core/src/targets/agentTarget.ts:267-278 with calls to this helper.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: febb8f0c-c64e-44e4-8919-2adad4e021a8
📒 Files selected for processing (3)
core/src/targets/agentTarget.tsskills/agent-redteaming/opfor-setup/catalog.jsonskills/mcp-redteaming/opfor-setup/catalog.json
🚧 Files skipped from review as they are similar to previous changes (2)
- skills/mcp-redteaming/opfor-setup/catalog.json
- skills/agent-redteaming/opfor-setup/catalog.json
jithin23-kv
force-pushed
the
fix/capture-http-errors
branch
from
July 21, 2026 05:59
0d7a781 to
20221e1
Compare
jithin23-kv
approved these changes
Jul 21, 2026
Collaborator
|
LGTM A couple of small things I pushed to the branch:
Thank you for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When the target agent returned an HTTP error with a response body, the CLI only displayed the status code (for example,
HTTP 400), making it difficult to identify the actual error.Solution
Capture the HTTP response body and include it in the
TargetStopErrormessage so the CLI displays both the status code and the server's error response.Changes
core/src/targets/agentTarget.tsto include the HTTP response body in error messages.Closes
Closes #176
How to test
400or500response with a JSON error body.Screenshots
N/A
Summary by CodeRabbit