fix - remove tab when deleted from file fixes: #923#940
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes uSync import cleanup so deleted tabs/groups are actually removed (not just their properties), accounting for changes in how CompositionPropertyGroups is reported in newer Umbraco versions.
Changes:
- Updates tab cleanup logic to detect inherited/composed tabs via
ContentTypeCompositioninstead ofCompositionPropertyGroups. - Refactors
CleanTabsto be less nested and to emituSyncChangewarnings when a tab can’t be removed due to remaining properties.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
uSync.Core/Serialization/Serializers/ContentTypeBaseSerializer.cs
Outdated
Show resolved
Hide resolved
uSync.Core/Serialization/Serializers/ContentTypeBaseSerializer.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #923 -
Think there was a change as to how
CompositionPropertyGroupsreports - in previous versions this only contained groups/tabs that where from composed doctypes, now it includes them all, so have had to change the method for finding the composed tabs, to reading them from each composition.also tidied up the logic, to make it easier to read (less nested if statements)