Task1: Write simple "Guess a number" game#41
Task1: Write simple "Guess a number" game#41AndriySmolskyy merged 9 commits intoKernel-GL-HRK:Olena.Kryzhanivskafrom
Conversation
Signed-off-by: Oleksii Vodka <oleksii.vodka@gmail.com>
Signed-off-by: Oleksii Vodka <oleksii.vodka@gmail.com>
Signed-off-by: Oleksii Vodka <oleksii.vodka@gmail.com>
Signed-off-by: saurier <kruzhanivska.olena212@gmail.com>
Signed-off-by: saurier <kruzhanivska.olena212@gmail.com>
Signed-off-by: saurier <kruzhanivska.olena212@gmail.com>
Signed-off-by: saurier <kruzhanivska.olena212@gmail.com>
Signed-off-by: saurier <kruzhanivska.olena212@gmail.com>
|
Please use labels if your pull request is ready for review |
|
Should the guess.c file pass checkpatch.pl check? glas@glas-ThinkPad-T450s:~/Projects/GL/BaseCamp_LinuxKernel/workspace/tmp/task1-simple-program$ ./checkpatch.pl --no-tree -f guess.c ERROR: do not initialise globals to 0 ERROR: Bad function definition - void generateRandom() should probably be void generateRandom(void) ERROR: Bad function definition - int main() should probably be int main(void) WARNING: please, no spaces at the start of a line
WARNING: Missing a blank line after declarations
WARNING: please, no spaces at the start of a line
WARNING: please, no spaces at the start of a line
WARNING: please, no spaces at the start of a line
WARNING: please, no spaces at the start of a line
ERROR: that open brace { should be on the previous line
ERROR: spaces required around that '==' (ctx:VxV)
ERROR: space required before the open parenthesis '('
WARNING: please, no spaces at the start of a line
ERROR: code indent should use tabs where possible
WARNING: please, no spaces at the start of a line
ERROR: code indent should use tabs where possible
WARNING: please, no spaces at the start of a line
WARNING: please, no spaces at the start of a line
WARNING: please, no spaces at the start of a line
ERROR: that open brace { should be on the previous line
ERROR: else should follow close brace '}'
WARNING: please, no spaces at the start of a line
ERROR: code indent should use tabs where possible
WARNING: please, no spaces at the start of a line
ERROR: code indent should use tabs where possible
WARNING: please, no spaces at the start of a line
WARNING: please, no spaces at the start of a line
total: 12 errors, 16 warnings, 30 lines checked NOTE: For some of the reported defects, checkpatch may be able to NOTE: Whitespace errors detected. guess.c has style problems, please review. NOTE: If any of the errors are false positives, please report |
AndriySmolskyy
left a comment
There was a problem hiding this comment.
The task1-simple-program/guess.c doesn't pass checking with checkpatch.pl
|
Check please |
Add .gitignore file and guecc.s file with "Guess a number" game. Random generator function is separate.