Task5: Hello module with proc_fs#101
Open
EugeneKolesnyk wants to merge 24 commits intoKernel-GL-HRK:mainfrom
Open
Task5: Hello module with proc_fs#101EugeneKolesnyk wants to merge 24 commits intoKernel-GL-HRK:mainfrom
EugeneKolesnyk wants to merge 24 commits intoKernel-GL-HRK:mainfrom
Conversation
Signed-off-by: EugeneKolesnyk <kolesnyk4996@gmail.com>
Signed-off-by: EugeneKolesnyk <kolesnyk4996@gmail.com>
Signed-off-by: EugeneKolesnyk <kolesnyk4996@gmail.com>
Signed-off-by: EugeneKolesnyk <kolesnyk4996@gmail.com>
Signed-off-by: EugeneKolesnyk <kolesnyk4996@gmail.com>
Signed-off-by: EugeneKolesnyk <kolesnyk4996@gmail.com>
Signed-off-by: EugeneKolesnyk <kolesnyk4996@gmail.com>
Signed-off-by: EugeneKolesnyk <kolesnyk4996@gmail.com>
Signed-off-by: EugeneKolesnyk <kolesnyk4996@gmail.com>
Signed-off-by: EugeneKolesnyk <kolesnyk4996@gmail.com>
Signed-off-by: EugeneKolesnyk <kolesnyk4996@gmail.com>
Signed-off-by: EugeneKolesnyk <kolesnyk4996@gmail.com>
…rning during compilation Signed-off-by: EugeneKolesnyk <kolesnyk4996@gmail.com>
Signed-off-by: EugeneKolesnyk <kolesnyk4996@gmail.com>
Signed-off-by: EugeneKolesnyk <kolesnyk4996@gmail.com>
Signed-off-by: EugeneKolesnyk <kolesnyk4996@gmail.com>
Signed-off-by: EugeneKolesnyk <kolesnyk4996@gmail.com>
Signed-off-by: EugeneKolesnyk <kolesnyk4996@gmail.com>
Signed-off-by: EugeneKolesnyk <kolesnyk4996@gmail.com>
Signed-off-by: EugeneKolesnyk <kolesnyk4996@gmail.com>
Signed-off-by: EugeneKolesnyk <kolesnyk4996@gmail.com>
Signed-off-by: EugeneKolesnyk <kolesnyk4996@gmail.com>
Signed-off-by: EugeneKolesnyk <kolesnyk4996@gmail.com>
task5-proc_fs/hello.c
Outdated
|
|
||
| static int __init hello_init(void) | ||
| { | ||
| procfs_buffer_size = sprintf(procfs_buffer, "%d + %d = %d\n", num1, num2, num1 + num2); |
Contributor
There was a problem hiding this comment.
Code style issues are here and below
task5-proc_fs/hello.c
Outdated
| proc_file = proc_create(PROC_FILE_NAME, 0666, proc_folder, &fops); | ||
| if (!proc_file) { | ||
| pr_err("HELLO: Error: Could not initialize /proc/%s/%s\n", PROC_DIR_NAME, PROC_FILE_NAME); | ||
| proc_remove(proc_file); |
Contributor
There was a problem hiding this comment.
No sense to call proc_remove(proc_file); here because proc_file is not valid.
task5-proc_fs/hello.c
Outdated
|
|
||
| static void __exit hello_exit(void) | ||
| { | ||
| pr_info("HELLO: Goodbye Kernel!\n"); |
Contributor
There was a problem hiding this comment.
Code style issues are here and below
task5-proc_fs/hello.c
Outdated
|
|
||
| to_copy = min(count, procfs_buffer_size); | ||
|
|
||
| not_copied = copy_to_user(buffer, procfs_buffer, to_copy); |
Contributor
There was a problem hiding this comment.
Per my understanding, if procfs_buffer_size variable is maintained and updated in the code below it is assumed that procfs_buffer contents can be read by the user space app by multiple reads.
For example 100 bytes buffer can be read by 2 hello_read calls with count set to 25 and 75.
But, data is copied to the user provided buffer from the beginning of the procfs_buffer, so the same data will be copied twice, what, per my understanding, is not expected.
AndriySmolskyy
requested changes
Mar 17, 2023
Contributor
AndriySmolskyy
left a comment
AndriySmolskyy
left a comment
There was a problem hiding this comment.
Please see my comments in the task5-proc_fs/hello.c file.
Signed-off-by: EugeneKolesnyk <kolesnyk4996@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.