03 module task#119
Open
marynamalakhova wants to merge 4 commits intoKernel-GL-HRK:Maryna.Malakhovafrom
Open
Conversation
AleksandrBulyshchenko
left a comment
AleksandrBulyshchenko
left a comment
There was a problem hiding this comment.
Please base your PRs on your branch at point which already includes task commit.
Task should be included via merge from master.
In this particular case you should merge 158b7e8 into https://github.com/Kernel-GL-HRK/gl-kernel-training-2021/commits/Maryna.Malakhova and rebase this PR onto that point.
The same is relevant for other PRs as well.
| #include <linux/module.h> // Core header for loading LKMs into the kernel | ||
| #include <linux/kernel.h> // Contains types, macros, functions for the kernel | ||
| #include <linux/module.h> // Core header for loading LKMs into the kernel | ||
| #include <linux/kernel.h> // Contains types, macros, functions for the kernel |
There was a problem hiding this comment.
Generally I'd ask to fix codestyle in place, but as this is a separate point of task, lets keep such fixup commit.
- You still have inconsistent indentation of comments (in includes block);
- Add
Fixesline in commit message per kernel standard;
AleksandrBulyshchenko
added
Change requested
marynamalakhova
force-pushed
the
03_module_task
branch
8 times, most recently
from
9b871ff to
9d76817
Compare
marynamalakhova
added
Ready for review
Author
|
Thank you for the review. I think. that I've fixed |
marynamalakhova
force-pushed
the
03_module_task
branch
4 times, most recently
from
645cd60 to
6353ce6
Compare
AleksandrBulyshchenko
left a comment
AleksandrBulyshchenko
left a comment
There was a problem hiding this comment.
Please rebase onto 158b7e8, as we agreed.
| $(MAKE) -C $(BUILD_KERNEL) M=$(CURDIR) modules | ||
|
|
||
| clean: | ||
| $(MAKE) -C $(BUILD_KERNEL) M=$(CURDIR) clean |
There was a problem hiding this comment.
Makefile expects BUILD_KERNEL being defined in environment,
but neither code, nor commit message don't explain this.
AleksandrBulyshchenko
added
Change requested
marynamalakhova
force-pushed
the
03_module_task
branch
from
6353ce6 to
b88d68a
Compare
marynamalakhova
added
Ready for review
Author
|
Thanks for the review, I`ve fixed |
Add Makefile, source file according to the lecture Module has been compiled and checked on Beaglebone BBB kernel has been made on the linux-stable 14.9y base Variable BUILD_KERNEL should be set in the environment for building BUILD_KERNEL should define path to the linux kernel source folder Signed-off-by: Maryna Malakhova <maryna.malakhova@globallogic.com>
Added parameter to module init and it is provided as a result Signed-off-by: Maryna Malakhova <maryna.malakhova@globallogic.com>
Init could return 0 or negative values Signed-off-by: Maryna Malakhova <maryna.malakhova@globallogic.com>
Add log file of module's output Signed-off-by: Maryna Malakhova <maryna.malakhova@globallogic.com>
marynamalakhova
force-pushed
the
03_module_task
branch
from
b88d68a to
da90cc1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a simple module realization and it`s log output from BBboard