Conversation
Add: game "Rock, Paper, Scissors" and Makefile for the game build Signed-off-by: volnsav <savchenko.volod@gmail.com>
Add: home task 03-bash/make_soup Fix: 03-bash. Format scripts and replace [[ with [ in 02-bash, add target "all", xchange main.o and hello in target "hello", remove unnecessary hyphen before rm, remove main and a.out from target "clean" Signed-off-by: volnsav <savchenko.volod@gmail.com>
Add: source and make files for create simple kernel module, dmesg logfile with trace log while load and unload kernel module Signed-off-by: volnsav <savchenko.volod@gmail.com>
Author
|
Add hometask 4 |
Signed-off-by: Andriy Khulap <andriy.khulap@globallogic.com>
Add: simple kernel module wich works with procfs and convert char in lower case to upper case, dmesg log file. Signed-off-by: volnsav <savchenko.volod@gmail.com>
Add: store and show convertor statistics in path /proc/myprocfs/stat, change convertor path to /proc/myprocfs/convertor. Signed-off-by: volnsav <savchenko.volod@gmail.com>
Add: simple lowercase converter based on sysfs classes, dmesg and shell log. Signed-off-by: volnsav <savchenko.volod@gmail.com>
Add: kernel module source file and log file Signed-off-by: volnsav <savchenko.volod@gmail.com>
Author
|
Add homework #6 |
DevyatovAndrey
requested changes
Nov 19, 2018
Contributor
DevyatovAndrey
left a comment
DevyatovAndrey
left a comment
There was a problem hiding this comment.
The minor changes are needed IMO
| [16121.523508] my_time: call my_timer_callback, delay: 5000 [ms] | ||
| [16126.639240] my_time: call my_timer_callback, delay: 5000 [ms] | ||
| [16131.754892] my_time: call my_timer_callback, delay: 5000 [ms] | ||
| [16134.670267] my_time: call my_store |
Contributor
There was a problem hiding this comment.
call my_store
I'm wondering how this can help in debugging?
It reflects just a fact of callback call, but what parameters were pased into?
Author
There was a problem hiding this comment.
value of delay (5000) is passed into.
| pr_info("my_time: call %s, can't read delay value!\n", __func__); | ||
| } | ||
|
|
||
| if (delta_in_ms < MIN_DELAY_IN_MS) { |
Contributor
There was a problem hiding this comment.
if (delta_in_ms < MIN_DELAY_IN_MS) {
In this case the timer will be restarted with default value, correct?
So the previous delay period successfully set before would be dropped.
| static void my_timer_callback(unsigned long data) | ||
| { | ||
| pr_info("my_time: call %s, delay: %lu [ms]\n", __func__, delta_in_ms); | ||
| mod_my_timer(); |
Contributor
There was a problem hiding this comment.
Looks like there is no way to stop this timer.
DevyatovAndrey
added
changes requested
Fix: set timer off if 0 obtained, improve debug messages Signed-off-by: volnsav <savchenko.volod@gmail.com>
volnsav
added
ready
and removed
changes requested
Author
|
Fix lesson 06 homework |
Add: kernel module source file and log (dmesg and system) Signed-off-by: volnsav <savchenko.volod@gmail.com>
Author
|
Add homework 7 task 01 - slab allocator |
Contributor
|
@volnsav, |
yekovalyov
reviewed
Jan 14, 2019
| clean: | ||
| rm -rf $(KITCHEN) | ||
|
|
||
|
|
Contributor
There was a problem hiding this comment.
Trailing empty lines in the end of file.
yekovalyov
reviewed
Jan 14, 2019
| # echo ">>>>>>>>>> dir >>>>>>>>>>> $1" | ||
| if ! [ -d $1 ]; then | ||
| mkdir -p $1 | ||
| fi |
Contributor
There was a problem hiding this comment.
Empty line is absent in the end of file.
yekovalyov
reviewed
Jan 14, 2019
yekovalyov
reviewed
Jan 14, 2019
| INSTALL_DIR="/usr/local/bin" | ||
| INSTALL_FILE="task1.sh" | ||
|
|
||
| if [ -z "$1" ]; then |
Contributor
There was a problem hiding this comment.
May be better to check the existing file using [ -f ... ]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix errors and merge commits