RadioScanner: swap react-marquee-text for react-fast-marquee#177
Merged
Conversation
…oScanner react-marquee-text measures once on mount and freezes when children change — the now-playing list turns over every time the virtual clock promotes or expires a segment. react-fast-marquee re-measures via ResizeObserver (pure CSS animation). duration->speed: constant px/s regardless of content length; textSpacing on the OFFLINE ticker becomes child padding (.rsOfflineText). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019NMS1V2keS3pTbWRemCd9o
|
✅ Playwright E2E — 1 passed · 0 failed · 0 flaky · 0 skipped |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The now-playing ticker froze whenever its content changed —
react-marquee-textmeasures once on mount, and the segment list turns over every time the virtual clock promotes/expires an item.react-fast-marqueere-measures via ResizeObserver and animates in pure CSS, so dynamic children are its documented use case.NowPlayingList:duration={10}→speed={40}(constant px/s — long lists no longer scroll faster to fit a fixed duration),pauseOnHoverkept.RadioScannerOFFLINE ticker:textSpacing="95%"has no equivalent; loop-repeat spacing is now child padding (.rsOfflineText).react-marquee-textremoved from deps; no CSS file import needed.Gates: tsc, eslint, 374 tests green.
🤖 Generated with Claude Code
https://claude.ai/code/session_019NMS1V2keS3pTbWRemCd9o