Skip to content

fix: align Node 22.23.4 with the Astro security update - #471

Open
KayzenRoot wants to merge 2 commits into
mainfrom
codex/coinblink-astro-node-alignment
Open

KayzenRoot wants to merge 2 commits into
mainfrom
codex/coinblink-astro-node-alignment

Conversation

@KayzenRoot

Copy link
Copy Markdown
Owner

What changed

  • Carry forward Dependabot's Astro 7.4.12 update from chore(deps-dev): bump astro from 7.3.8 to 7.4.12 #470 and align the application, Docker and CI with Node 22.23.4.
  • Pin the Node version in .node-version for the app workflows. Changes to the pin trigger the relevant path-filtered checks.
  • Add the system CA bundle to the Docker base used to build and run Wrangler. The slim image used for the Linux validation lacked that bundle.

Validation

  • Confirmed that 33 Node setup steps read the pin after checkout and that the manifest, lockfile and Docker image agree with Astro's Node requirement.
  • Local build, audit, container and hosted checks are in progress. The Stripe test provisioning workflow is outside the change because editing it would trigger provisioning when the change reaches main.

dependabot Bot and others added 2 commits November 18, 2026 15:51
Bumps [astro](https://github.com/withastro/astro/tree/HEAD/packages/astro) from 7.3.8 to 7.4.12.
- [Release notes](https://github.com/withastro/astro/releases)
- [Changelog](https://github.com/withastro/astro/blob/main/packages/astro/CHANGELOG.md)
- [Commits](https://github.com/withastro/astro/commits/astro@7.4.12/packages/astro)

---
updated-dependencies:
- dependency-name: astro
  dependency-version: 7.4.12
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
Copilot AI lite review requested due to automatic review settings November 18, 2026 18:56
@ecc-tools

ecc-tools Bot commented Nov 18, 2026

Copy link
Copy Markdown

ECC Tools / Security Evidence

Commit: 6e8a9dd52df4bdf7372404cc894b0583aaf78af0

Security evidence gate passed (success)

No security-sensitive scanner-evidence gap detected.

Mode: enforce

Scanned 34 changed file(s). No missing scanner-evidence signal was detected.

Check publication was denied or unavailable. An app owner must enable Checks: read and write, and the installation owner must approve the updated permission.

@ecc-tools

ecc-tools Bot commented Nov 18, 2026

Copy link
Copy Markdown

ECC Tools / PR Risk Taxonomy

Commit: 6e8a9dd52df4bdf7372404cc894b0583aaf78af0

PR taxonomy review recommended (neutral)

Detected 4 PR taxonomy bucket(s): Security Evidence, Install Manifest Integrity, CI/CD Recommendation, Cost/Token Risk.

Scanned 34 changed file(s).

Roadmap taxonomy buckets:

Security Evidence

Security-sensitive changes should carry explicit scanner, code-scanning, or focused regression evidence.

Signals:

  • 29 security-sensitive path(s) changed

Paths:

  • .github/workflows/brand-demo-qa.yml
  • .github/workflows/build.yml
  • .github/workflows/ci-quality.yml
  • .github/workflows/cloudflare-production.yml
  • .github/workflows/cost-report.yml
  • .github/workflows/local-journey-browser.yml
  • .github/workflows/m01-m05-browser.yml
  • .github/workflows/m01-visual-preview.yml

Install Manifest Integrity

Install manifests, plugin metadata, and shipped skills should stay synchronized with user-facing setup guidance.

Signals:

  • 2 install or manifest path(s) changed

Paths:

  • package-lock.json
  • package.json

CI/CD Recommendation

CI, dependency, coverage, and contract signals should be routed into follow-up checks or verification work.

Signals:

  • CI workflow changes may ship without failure-mode evidence
  • 31 CI or workflow path(s) changed

Paths:

  • .github/workflows/brand-demo-qa.yml
  • .github/workflows/build.yml
  • .github/workflows/ci-quality.yml
  • .github/workflows/cloudflare-production.yml
  • .github/workflows/cost-report.yml
  • .github/workflows/local-journey-browser.yml
  • .github/workflows/m01-m05-browser.yml
  • .github/workflows/m01-visual-preview.yml

Cost/Token Risk

AI routing, usage, and token-budget changes should include budget or usage-limit evidence.

Signals:

  • Cost or token-risk changes may ship without budget evidence
  • 0 cost/token path(s) changed

Paths:

  • .github/workflows/brand-demo-qa.yml
  • .github/workflows/build.yml
  • .github/workflows/ci-quality.yml

Check publication was denied or unavailable. An app owner must enable Checks: read and write, and the installation owner must approve the updated permission.

@ecc-tools

ecc-tools Bot commented Nov 18, 2026

Copy link
Copy Markdown

ECC Tools / Reference Set Readiness

Commit: 6e8a9dd52df4bdf7372404cc894b0583aaf78af0

Reference set readiness gaps detected (neutral)

Reference evidence present for 1/7 areas (14%) across 34 changed file(s).

This check is based on files changed in this PR. Repository-level readiness is still reported by /ecc-tools analyze comments and generated manifests.

Area Status Evidence / Next Step
Deep analyzer corpus Missing Add analyzer fixture, golden, benchmark, or reference-set files that can catch analyzer regressions.
RAG/evaluator comparison Missing Add retrieval or evaluator reference-set comparison fixtures with expected ranking behavior.
PR salvage/review corpus Missing Add stale-PR, review-thread, reopen-flow, or salvage reference cases for queue cleanup automation.
Discussion triage corpus Missing Add public discussion triage fixtures, golden cases, or reference sets for informational, answered, and no-response classifications.
Harness compatibility Missing Add cross-harness, adapter-compliance, or harness-audit evidence for Claude, Codex, OpenCode, Zed, dmux, and agent surfaces.
Security evidence Present .github/workflows/security-analysis.yml
CI failure-mode evidence Missing Add captured CI failure logs, dry-run fixtures, or troubleshooting docs for common workflow failure modes.

Check publication was denied or unavailable. An app owner must enable Checks: read and write, and the installation owner must approve the updated permission.

@ecc-tools

ecc-tools Bot commented Nov 18, 2026

Copy link
Copy Markdown

ECC Tools / Hosted Promotion Readiness

Commit: 6e8a9dd52df4bdf7372404cc894b0583aaf78af0

Hosted promotion readiness passed (success)

No hosted promotion evidence gaps detected across 34 changed file(s); 0 corpus scenarios had matching evidence.

This check compares PR file changes against the evaluator/RAG promotion corpus in src/analyzers/fixtures/evaluator-rag-corpus.ts.
Hosted output scoring inspected 0 completed cached hosted job results.

No evaluator corpus scenarios matched this PR.

Check publication was denied or unavailable. An app owner must enable Checks: read and write, and the installation owner must approve the updated permission.

@ecc-tools

ecc-tools Bot commented Nov 18, 2026

Copy link
Copy Markdown

ECC Tools / PR Config Audit

Commit: 6e8a9dd52df4bdf7372404cc894b0583aaf78af0

No changed-config issues detected (success)

Scanned 29 config file(s) present at this commit across 29 changed config path(s) and found no issues in the supported security rules.

Changed config files:

  • .github/workflows/brand-demo-qa.yml
  • .github/workflows/build.yml
  • .github/workflows/ci-quality.yml
  • .github/workflows/cloudflare-production.yml
  • .github/workflows/cost-report.yml
  • .github/workflows/local-journey-browser.yml
  • .github/workflows/m01-m05-browser.yml
  • .github/workflows/m01-visual-preview.yml
  • .github/workflows/m02-news-browser.yml
  • .github/workflows/m03-sources-browser.yml
  • .github/workflows/m04-market-browser.yml
  • .github/workflows/m05-local-cms-browser.yml
  • .github/workflows/m05-owner-access.yml
  • .github/workflows/m06-local-owner-dashboard.yml
  • .github/workflows/m07-local-social-studio.yml
  • .github/workflows/m07c-local-calendar.yml
  • .github/workflows/m07d-local-week-board.yml
  • .github/workflows/m09-seo-metadata.yml
  • .github/workflows/m11-developer-demo.yml
  • .github/workflows/m12-local-quota-preview.yml
  • .github/workflows/m13-local-placement-preview.yml
  • .github/workflows/m14-incident-drill.yml
  • .github/workflows/m15-local-launch-checklist.yml
  • .github/workflows/m16-local-watchlist.yml
  • .github/workflows/m17-local-storyboard.yml
  • .github/workflows/pr-assurance.yml
  • .github/workflows/reviewdog.yml
  • .github/workflows/security-analysis.yml
  • .github/workflows/site-surfaces.yml

Check publication was denied or unavailable. An app owner must enable Checks: read and write, and the installation owner must approve the updated permission.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

@ecc-tools

ecc-tools Bot commented Nov 18, 2026

Copy link
Copy Markdown

ECC Tools / PR Harness Audit

Commit: 6e8a9dd52df4bdf7372404cc894b0583aaf78af0

No harness issues detected (success)

Scanned 29 changed config file(s) and found no harness issues.

Changed config files:

  • .github/workflows/brand-demo-qa.yml
  • .github/workflows/build.yml
  • .github/workflows/ci-quality.yml
  • .github/workflows/cloudflare-production.yml
  • .github/workflows/cost-report.yml
  • .github/workflows/local-journey-browser.yml
  • .github/workflows/m01-m05-browser.yml
  • .github/workflows/m01-visual-preview.yml
  • .github/workflows/m02-news-browser.yml
  • .github/workflows/m03-sources-browser.yml
  • .github/workflows/m04-market-browser.yml
  • .github/workflows/m05-local-cms-browser.yml
  • .github/workflows/m05-owner-access.yml
  • .github/workflows/m06-local-owner-dashboard.yml
  • .github/workflows/m07-local-social-studio.yml
  • .github/workflows/m07c-local-calendar.yml
  • .github/workflows/m07d-local-week-board.yml
  • .github/workflows/m09-seo-metadata.yml
  • .github/workflows/m11-developer-demo.yml
  • .github/workflows/m12-local-quota-preview.yml
  • .github/workflows/m13-local-placement-preview.yml
  • .github/workflows/m14-incident-drill.yml
  • .github/workflows/m15-local-launch-checklist.yml
  • .github/workflows/m16-local-watchlist.yml
  • .github/workflows/m17-local-storyboard.yml
  • .github/workflows/pr-assurance.yml
  • .github/workflows/reviewdog.yml
  • .github/workflows/security-analysis.yml
  • .github/workflows/site-surfaces.yml

Check publication was denied or unavailable. An app owner must enable Checks: read and write, and the installation owner must approve the updated permission.

@socket-security

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatedastro@​7.3.8 ⏵ 7.4.1297100 +38898100

View full report

@sonarqubecloud

Copy link
Copy Markdown

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants