Skip to content

Fix Portuguese redaction terminology and copy in the pt catalog - #27

Merged
Kayforkind merged 1 commit into
mainfrom
i18n/pt-catalog-review
Oct 31, 2026
Merged

Kayforkind merged 1 commit into
mainfrom
i18n/pt-catalog-review

Conversation

@Kayforkind

Copy link
Copy Markdown
Owner

Refs #7. This is a copy-review pass on the existing machine-drafted catalog, not a new locale.

Variant

pt-BR — the catalog was already consistent Brazilian Portuguese (no ficheiro/ecrã/utilizador forms), and this PR keeps it that way.

What changed

  • Redaction was mistranslated as "Redigir", which in Portuguese means "to write / draft a text". The tool read like a text editor rather than a redaction tool, and the same wrong stem carried through the tool label, shortcut hint, help section, export note and the failure/verification toasts. Changed to "Tarjar" / "tarja", the standard pt-BR term for blacking out content.
  • Flip labels said "Inverter H/V" while their tooltips say "Espelhar …" — now both say "Espelhar".
  • AcroForm field kinds: "Marcação"/"Opção" were ambiguous (and "Opção" collided with "Escolha") — now "Caixa"/"Botão de opção".
  • Grammar/anglicism fixes: comma splice in the privacy note, "escalar" → "redimensionar" for resizing, "gravados" → "incorporados" for burned-in marks, "Gire a página para ficar reta" → "Endireite a página", "é preciso de conexão" → "é necessária uma conexão", tautological "extremidade final" → "outra extremidade", "Excluir remove o item" → "Excluir apaga o item".

Acceptance criteria from #7

  • All keys present — catalog is key-identical to English (378 keys), src/lib/i18n.test.ts passes.
  • npm test green (88/88, 12 files); npm run typecheck clean; node scripts/check-consistency.cjs OK.
  • Portuguese appears in the in-app language switcher (pt in LANGUAGES).
  • No other source files touched — one file changed, src/locales/pt/translation.json.

Disclosure

I am not a native Portuguese speaker; this review is AI-assisted. Per the issue's own note, the catalog still deserves a native speaker's read before #7 is closed, so this PR deliberately does not auto-close it.

"Redact" was translated as "Redigir", which means "to write/draft" — the tool
read as a text editor rather than a redaction tool. Use "tarjar"/"tarja", the
standard pt-BR term for blacking out content, across the tool label, shortcut,
help text, and export/verification messages. Also align the flip labels with
their tooltips, clarify the AcroForm field-kind labels, fix the comma splice in
the privacy note, and replace anglicisms ("escalar" for resize, "gravados" for
burned in) with natural pt-BR wording.

The catalog stays key-identical to English (378 keys); the i18n parity tests
and the full suite pass.

🤖 Generated with Codebuff
Co-Authored-By: Codebuff <noreply@codebuff.com>
@coderabbitai

coderabbitai Bot commented Oct 31, 2026

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: fab500ca-2371-48b3-8770-c9c5cfda1cb7
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@Kayforkind

Copy link
Copy Markdown
Owner Author

CI note: the verify failure is pre-existing, not from this PR

verify stops at the Dependency audit (prod) step, before any code is checked:

qs : qs.stringify with arrayFormat 'comma' throws an uncaught TypeError ... GHSA-6pq8-jhm2-2vcw
##[error]Process completed with exit code 1.

This PR changes only src/locales/pt/translation.json (git diff --name-only origin/main → one file), with no changes to package.json, package-lock.json or packages/, so the audit result is identical on main. The last green CI run on main was 2026-10-17; the qs, ip-address and zod advisories were published after that, so main now fails this gate too.

I deliberately did not bump the lockfile here: issue #7 asks for the locale change only, and CONTRIBUTING asks for one change per PR. Dependency updates belong in a separate PR (or the existing Dependabot setup).

The steps the audit gate blocks were run manually against this branch:

Step Result
npm run typecheck pass
npm test 88/88 pass (12 files)
npx vitest run src/lib/i18n.test.ts 15/15 pass (key parity, placeholders, markup)
node scripts/check-consistency.cjs consistency OK: 88 tests, Node 22
npm run build:pages pass, built in 21.43s

@Kayforkind
Kayforkind merged commit 578c55b into main Oct 31, 2026
1 of 2 checks passed
@Kayforkind
Kayforkind deleted the i18n/pt-catalog-review branch October 31, 2026 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant