Skip to content

change the network in docker-compose#370

Open
m0533199321 wants to merge 2 commits intomainfrom
malka/notifications
Open

change the network in docker-compose#370
m0533199321 wants to merge 2 commits intomainfrom
malka/notifications

Conversation

@m0533199321
Copy link
Copy Markdown
Collaborator

No description provided.

@greptile-apps
Copy link
Copy Markdown

greptile-apps Bot commented Nov 12, 2025

Greptile Overview

Greptile Summary

Added explicit name: ag_cloud to the network definition and commented out the deprecated version field. However, this PR includes far more than just network changes - it adds multiple new services (sound_metrics, ripeness-api, camera/soil inference services, image-linker, alertmanager services, sounds_flink), replaces Kafka Connect with mqtt-router, updates bucket names from telemetry to sound, and changes db_api_service to connect to postgres:5432 instead of host.docker.internal:5432.

Key changes:

  • Network definition now explicitly names the bridge network as ag_cloud
  • Replaced Kafka Connect architecture with mqtt-router for simpler MQTT-to-Kafka routing
  • Added numerous new microservices expanding the platform capabilities
  • Changed database connection from host.docker.internal to postgres service name (proper containerization)
  • Updated bucket naming from telemetry to sound across multiple services
  • Added several new Flink job dispatchers for different inference types

Confidence Score: 3/5

  • This PR is moderately safe but requires careful testing due to the scope of changes
  • The PR title "change the network in docker-compose" is misleading - this includes 550 additions and 176 deletions with numerous architectural changes. While the network change itself (adding explicit name: ag_cloud) is safe and follows best practices, the PR bundles many unrelated changes including new services, architectural refactoring (Kafka Connect → mqtt-router), database connection changes, and bucket renaming. This makes it difficult to review comprehensively and increases deployment risk. The changes appear technically sound individually, but the large scope and misleading title reduce confidence.
  • docker-compose.yml requires careful testing - verify all service dependencies, network connectivity within ag_cloud network, and that the database connection change from host.docker.internal to postgres works in your deployment environment

Important Files Changed

File Analysis

Filename Score Overview
docker-compose.yml 3/5 Added explicit network name ag_cloud, commented out version field, added many new services (sound_metrics, ripeness-api, camera/soil inference services, multiple Flink jobs, image-linker, alertmanager services), replaced Kafka Connect with mqtt-router, changed bucket names from telemetry to sound, and updated service configurations - much more than just network changes

Sequence Diagram

sequenceDiagram
    participant Client
    participant AgCloud as ag_cloud Network
    participant Postgres
    participant Kafka
    participant MinioHot as minio-hot
    participant MQTT as mosquitto
    participant Router as mqtt-router
    participant DBApi as db_api_service
    participant Services as Other Services

    Note over AgCloud: Explicitly named network: "ag_cloud"
    
    Client->>AgCloud: docker-compose up
    AgCloud->>Postgres: Start on ag_cloud network
    AgCloud->>Kafka: Start on ag_cloud network
    AgCloud->>MinioHot: Start on ag_cloud network
    AgCloud->>MQTT: Start on ag_cloud network
    
    Note over Router: Replaces Kafka Connect
    MQTT->>Router: MQTT messages
    Router->>Kafka: Forward to Kafka topics
    
    Note over DBApi: Now connects via ag_cloud network
    DBApi->>Postgres: Connect to postgres:5432<br/>(was host.docker.internal)
    
    Services->>MinioHot: Connect via minio-hot:9000
    Services->>Kafka: Connect via kafka:9092
    Services->>Postgres: Connect via postgres:5432
    
    Note over AgCloud: All services communicate<br/>within named network
Loading

Copy link
Copy Markdown

@greptile-apps greptile-apps Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant