structure: consolidate all pipeline under airflow/leaf-pipeline; prop…#333
Open
Sara-git-218 wants to merge 1 commit intomainfrom
Open
structure: consolidate all pipeline under airflow/leaf-pipeline; prop…#333Sara-git-218 wants to merge 1 commit intomainfrom
Sara-git-218 wants to merge 1 commit intomainfrom
Conversation
…er .gitignore & LFS
There was a problem hiding this comment.
Greptile Overview
Greptile Summary
This PR consolidates pipeline code into a Git submodule at airflow/leaf-pipeline and adds Git LFS support for ML model weights.
Critical Issues:
.gitignorechanges removed security patterns (*.env,*.crt,*/certs/,**/secrets/), exposing existing tracked sensitive files including database credentials and certificates- The
airflow/leaf-pipelinesubmodule is missing.gitmodulesconfiguration, preventing proper initialization
Changes Made:
- Added
.gitattributesto track ML weights (*.pt, *.pth, *.safetensors) via Git LFS - Simplified
.gitignoreto focus onleaf-pipelinespecific patterns - Added
airflow/leaf-pipelineas a Git submodule (commit 181ad13)
Required Actions:
- Restore removed
.gitignorepatterns immediately - Add
.gitmodulesfile to properly register the submodule - Remove already-tracked sensitive files from git history
Confidence Score: 0/5
- This PR introduces critical security vulnerabilities and breaks submodule functionality
- Score of 0 reflects two critical issues: (1) removal of security patterns from
.gitignoreexposes sensitive credentials and certificates that are already tracked in the repository, creating immediate security risks; (2) missing.gitmodulesconfiguration breaks submodule initialization for all future clones .gitignorerequires immediate restoration of security patterns, and.gitmodulesfile must be created to register the submodule
Important Files Changed
File Analysis
| Filename | Score | Overview |
|---|---|---|
| .gitignore | 0/5 | Removed security-critical patterns allowing secrets, certs, and credentials to be tracked in git |
| .gitattributes | 5/5 | Added Git LFS configuration for ML model weight files (*.pt, *.pth, *.safetensors) |
| airflow/leaf-pipeline | 1/5 | Added submodule without .gitmodules configuration, breaking submodule initialization |
Sequence Diagram
sequenceDiagram
participant Dev as Developer
participant Git as Git Repository
participant Sub as leaf-pipeline Submodule
participant LFS as Git LFS
Dev->>Git: Add .gitattributes for LFS
Note over Git,LFS: Configure *.pt, *.pth, *.safetensors for LFS
Dev->>Git: Modify .gitignore
Note over Git: Remove *.env, *.crt, */certs/, **/secrets/
Note over Git: SECURITY ISSUE: Exposes existing tracked files
Dev->>Git: Add airflow/leaf-pipeline submodule
Note over Git,Sub: Submodule commit 181ad13 added
Git--xSub: Missing .gitmodules configuration
Note over Sub: Submodule cannot be initialized properly
Dev->>Git: Commit changes
Note over Git: Sensitive files (*.env, *.crt) now exposed
3 files reviewed, 2 comments
| @@ -0,0 +1 @@ | |||
| Subproject commit 181ad13327d1f0ab2e6d1d80622cc1717584908a | |||
There was a problem hiding this comment.
logic: Missing .gitmodules file to register this submodule. Without it:
git submodulecommands fail- New clones won't initialize the submodule
- The submodule URL/branch isn't documented
Add .gitmodules:
[submodule "airflow/leaf-pipeline"]
path = airflow/leaf-pipeline
url = <repository-url>
Comment on lines
+1
to
+29
| # --- כלליים --- | ||
| __pycache__/ | ||
| *.pyc | ||
| *.pyo | ||
| *.pyd | ||
| *.pytest_cache/ | ||
| *.log | ||
| *.pid | ||
| *.sqlite* | ||
| *.db | ||
| .ipynb_checkpoints/ | ||
| .env | ||
| .venv/ | ||
| venv/ | ||
| .coverage | ||
|
|
||
| # --- VSCode / Editor --- | ||
| .vscode/ | ||
| .idea/ | ||
|
|
||
| # --- Docker / Build --- | ||
| *.log | ||
| *.pid | ||
| *.bak | ||
| *.tmp | ||
| *.swp | ||
| .env.local | ||
| .env.* | ||
| !.env.example | ||
| # --- Docker/Airflow כלליים --- | ||
| logs/ | ||
| airflow/airflow.db | ||
| airflow/*.pid | ||
| airflow/*.log | ||
|
|
||
| # --- OS files --- | ||
| .DS_Store | ||
| Thumbs.db | ||
| # --- leaf-pipeline (מרוכז) --- | ||
| airflow/leaf-pipeline/**/__pycache__/ | ||
| airflow/leaf-pipeline/**/.ipynb_checkpoints/ | ||
| airflow/leaf-pipeline/**/logs/ | ||
| airflow/leaf-pipeline/**/runs_local/ | ||
| airflow/leaf-pipeline/**/out_*/ | ||
| airflow/leaf-pipeline/**/alerts.db | ||
|
|
||
| # אל תעקוב אחרי קובצי גיבוי אקראיים | ||
| *.bak.* | ||
| *.backup-*.tar.gz |
There was a problem hiding this comment.
logic: Removed critical security patterns from .gitignore that are now allowing sensitive files to be tracked:
*.envfiles - at least one.envwith database credentials is now in git*.crtcertificate files - certificate files are now tracked*/certs/and**/secrets/directories.vscode/and.idea/editor configs
These patterns MUST be restored immediately.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…er .gitignore & LFS