Repository navigation
Conversation
…-request-part-2-suneox
The held-expenses and pending-card-transactions block modals always said "Unable to submit report" even when the triggering button showed "Mark as done". Thread the existing mark-as-done flag into the shared modal helpers and add matching title and description strings so the modal copy follows the button copy.
…e-selected-order Move selected distance rate to the top of the rate list
… useReportActionsNewActionLiveTail hooks
…apshot-blocks-recovery # Conflicts: # src/hooks/useSearchPageSetup.ts
The Search transaction row and grouped report header can render their action button as "Done" but showed the block modals with the submit copy. Add a useShouldShowMarkAsDone hook that wraps the track-intent NVP read, thread its result into the block modal helpers from both components, and lift the ActionCell's internal computation into an isMarkAsDone prop so each row computes the flag once for both the button text and the modals.
Each component already subscribes to the track-intent NVP for other calls, so read it locally and pass it to shouldShowMarkAsDone directly instead of wrapping the pair in a hook. The ActionCell isMarkAsDone prop lift stays so each search row computes the flag once for both the button text and the block modals.
…zybowski/reorganize-home Move Recently added to right column and remove Announcements from Home
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Temporary infrastructure-only PR used to materialize the exact Expensify/App PR Expensify#93877 head and Android emulator runtime as short-lived workflow artifacts for an interactive regression test. This PR will be closed and the temporary branch removed after the recording is produced.