Repository navigation
Conversation
… comments The FreezeWrapper tweak is removed: a runtime probe showed the split's wrapper only ever observes the tab navigator's state ([Home, ReportsSplitNavigator, SearchFullscreenNavigator, SettingsSplitNavigator, WorkspaceNavigator]), so the RightModalNavigator -- a root-stack sibling -- never appears there and the added side-modal check could never be true. Opening an RHP already left the underlying split unfrozen, since the RHP is not in FULL_SCREENS_SET, so the change was a no-op and the shared navigation infra is left untouched. Also applies the reviewer's comment simplifications and removes a duplicated comment.
CI spellchecks each changed file in full, so touching Navigation.ts surfaces 'dispatchable' from a654a36 (main) even though those lines aren't part of this PR.
…om/huult/App into 83847-migrate-merge-transaction-v2
…ection-initial-order Fix initial selected ordering in approver selection lists
…-onyx-connect-mention-suggestions-part-18
…-onyx-connect-contact-methods-part-19
…yx-deps-batch-h-recreate
…efaultVendorRow [Payment due @mkhutornyi] Sage Intacct: Default vendor as navigable arrow row with updated copy
Co-authored-by: Issa Nimaga <inimaga@users.noreply.github.com>
…-opens-spend-after-inbox-merge Fix merge navigation from Inbox opening Spend tab
…tion-status-and-last-sync-for-bank-accounts-and-cards feat: show connection status and last sync time for bank accounts and cards
…t-rhp-closes-after-attendees-save fix report rph closes after attendees save
…quest-part-1-suneox Migrate money request destination step to dynamic routes (Expensify#83850 part 1)
…dDate-policy-onyx [No QA] Add archivedDate to the Policy Onyx type
…-tab-defer-central-report-v2 perf: defer central report list on Inbox tab navigation
Spend-Hybrid-Tap on checkbox does not select the group
…ngleLineGuard Fix: keep "Add receipt" label on one line in compact confirmation banner
Expense - Two different contacts are selected when trying to submit IOU
…op-token-ownership Prevent a background avatar picker from adopting a live crop draft
…t-rules-spreadsheet-import [No QA] Docs updates for E/A#95105 Merchant Rules spreadsheet import flow
…doCounts-stabilize Stabilize useTodoCounts result reference
…-toggle-multilevel-tags Hide top-level required tag toggle for independent multi-level tags
[CP staging] prevent trial payment reminder modal flicker on login
commented
Jul 28, 2026
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[No QA] Remove redundant type assertions from test suites
Explanation of Change
This test-only cleanup removes redundant unsafe type assertions from ten
existing test suites. It replaces them with production-derived signatures and
repository-native typed fixtures while preserving each test scenario and
runtime behavior. The MFA mock retains a typed forwarding wrapper so Jest's
hoisted module factory exposes a callable export.
Fixed Issues
$ Expensify#94739
PROPOSAL: Expensify#94739
Tests
lint, format, React compiler, and targeted Jest.
Offline tests
Not applicable: this PR changes test typing only and no product runtime code.
QA Steps
No QA required for this test-only cleanup.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos