Avoid Linux precompile hangs in live workload#1274
Closed
quinnj wants to merge 1 commit into
Closed
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1274 +/- ##
==========================================
+ Coverage 84.88% 84.91% +0.03%
==========================================
Files 28 28
Lines 10711 10713 +2
==========================================
+ Hits 9092 9097 +5
+ Misses 1619 1616 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
Closing this. The workaround shape here is not the right answer for issue #1252; we need to continue root-cause investigation instead of disabling the workload. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Base.timedwaitfor the HTTP precompile workload watchdog instead ofReseau.IOPoll.timedwaitPreferencesas a direct dependency since HTTP now reads its ownprecompile_workloadpreferenceContext
Issue #1252 is still reproducible for affected Linux users even with
Reseau@1.1.4. The issue history points at the live HTTP precompile workload:precompile_workload=falseavoids the hang, and the reports are on Linux Julia 1.11/1.12 while Julia 1.10 eventually completes.This keeps the workload enabled by default for macOS/Windows and Linux Julia 1.10, but avoids running live local servers/requests during precompile for the Linux Julia 1.11+ lane where users are hanging. Users can still explicitly opt in with
precompile_workload=true.Testing
julia --project=. -e 'using HTTP; HTTP._run_precompile_workload!(); println("precompile workload ok")'julia +1.10.11 --startup-file=no -e 'using Pkg; tmp = mktempdir(); Pkg.activate(tmp); Pkg.develop(path="/tmp/http-1252-fix"); Pkg.precompile(); using HTTP; @show VERSION; @show HTTP._precompile_workload_enabled(); @show Base.timedwait(() -> true, 1.0; pollint=0.01)'docker run --rm --platform linux/arm64 -v /tmp/http-1252-fix:/work -e JULIA_DEPOT_PATH=/tmp/julia-depot-arm julia:1.12.6 --startup-file=no -e 'using Pkg; Pkg.activate(temp=true); Pkg.develop(path="/work"); Pkg.precompile(); using HTTP; @show Sys.islinux(); @show VERSION; @show HTTP._precompile_workload_enabled()'julia --project=. -e 'using Pkg; Pkg.test()'Co-authored by Codex